Add Mage-OS to the CI matrix - #35
Open
michielgerritsen wants to merge 2 commits into
Open
Conversation
The michielgerritsen/magento-project-community-edition images have moved to ghcr.io/controlaltdelete-nl/magento2-in-a-box/magento-project-community-edition. The integration test matrix also drops the -debug suffix from the PHP 7.4 leg. GHCR does not publish -debug variants, so 2.3.7-p4-debug could not be resolved; 2.3.7-p4 is used instead.
The GHCR registry also publishes Mage-OS images, as a separate package (mage-os-community-edition) rather than extra tags on the Magento one. The image name therefore becomes a matrix value: MAGENTO_VERSION is replaced by IMAGE and IMAGE_VERSION, which together form the full tag. Adds a Mage-OS 3.3.0 leg on PHP 8.4 to every matrix. Coverage in the integration tests was gated on PHP_VERSION == 'php84-fpm'. The Mage-OS leg also runs on PHP 8.4, which would have produced a second Codecov upload for the same flag, so the gate now uses an explicit COVERAGE flag set on a single leg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #34. GitHub cannot base a pull request on a branch that
lives in a fork, so this pull request also contains the commit from #34.
Please merge #34 first; this diff then reduces to the Mage-OS commit alone.
The GHCR registry also publishes Mage-OS images, as a separate package
(mage-os-community-edition) rather than extra tags on the Magento one. The
image name therefore becomes a matrix value: MAGENTO_VERSION is replaced by
IMAGE and IMAGE_VERSION, which together form the full tag.
Adds a Mage-OS 3.3.0 leg on PHP 8.4 to every matrix.
Coverage in the integration tests was gated on PHP_VERSION == 'php84-fpm'.
The Mage-OS leg also runs on PHP 8.4, which would have produced a second
Codecov upload for the same flag, so the gate now uses an explicit COVERAGE
flag set on a single leg.