Skip to content

[BUGFIX] Parse comment(s) immediately preceding selector (part 2) #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverklee merged 1 commit into from
Dec 16, 2025
Merged

[BUGFIX] Parse comment(s) immediately preceding selector (part 2) #1424

oliverklee merged 1 commit into from
Dec 16, 2025

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Dec 12, 2025

No description provided.

@JakeQZ JakeQZ self-assigned this Dec 12, 2025
@JakeQZ JakeQZ marked this pull request as draft December 12, 2025 23:54
@coveralls
Copy link

coveralls commented Dec 12, 2025 •
edited
Loading

Coverage Status

coverage: 69.127%. remained the same
when pulling e6730ac on bugfix/comment-before-selector-2
into 515317d on main.

@JakeQZ JakeQZ force-pushed the bugfix/comment-before-selector-2 branch 3 times, most recently from df8a948 to bd45f43 Compare December 14, 2025 23:30
JakeQZ added a commit that referenced this pull request Dec 15, 2025
@JakeQZ
[TASK] Consume to EOF in DeclarationBlock::parse() upon failure
049f1a0 
This is not the right long-term fix - see #1430.

For now it is a sticking-plaster to help complete #1424.
@JakeQZ JakeQZ mentioned this pull request Dec 15, 2025
Merged
oliverklee pushed a commit that referenced this pull request Dec 15, 2025
@JakeQZ
[TASK] Consume to EOF in DeclarationBlock::parse() upon failure (#1431
e94cb16 
)

This is not the right long-term fix - see #1430.

For now it is a sticking-plaster to help complete #1424.
@JakeQZ JakeQZ force-pushed the bugfix/comment-before-selector-2 branch 2 times, most recently from 14592f7 to 3987549 Compare December 15, 2025 19:09
@JakeQZ JakeQZ marked this pull request as ready for review December 15, 2025 19:10
@JakeQZ JakeQZ requested a review from oliverklee December 15, 2025 19:10
@JakeQZ JakeQZ changed the title [BUGFIX] Parse comment(s) immediately preceding selector - part 2 [BUGFIX] Parse comment(s) immediately preceding selector (part 2) Dec 15, 2025
oliverklee
oliverklee reviewed Dec 15, 2025
View reviewed changes
@JakeQZ JakeQZ force-pushed the bugfix/comment-before-selector-2 branch 2 times, most recently from 1c59371 to 3ede1c4 Compare December 16, 2025 01:38
@JakeQZ JakeQZ marked this pull request as draft December 16, 2025 02:10
@oliverklee
Copy link
Collaborator

oliverklee commented Dec 16, 2025

I've merged the other PR. This PR now needs a rebase.

@JakeQZ
[BUGFIX] Parse comment(s) immediately preceding selector (part 2)
e6730ac 
Now comments with no whitespace before the selector are parsed and extracted.

`setSelectors()` also receives the same fix, for the unlikely case when
someone calls it with a selector string beginning with a comment.
@JakeQZ JakeQZ force-pushed the bugfix/comment-before-selector-2 branch from 3ede1c4 to e6730ac Compare December 16, 2025 09:49
@JakeQZ JakeQZ marked this pull request as ready for review December 16, 2025 09:51
@JakeQZ JakeQZ requested a review from oliverklee December 16, 2025 09:51
@oliverklee oliverklee merged commit ca51e51 into main Dec 16, 2025
23 checks passed
@oliverklee oliverklee deleted the bugfix/comment-before-selector-2 branch December 16, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

bug cleanup

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

3 participants

@JakeQZ @coveralls @oliverklee