Move save API from librecomp to ultramodern#137
Open
gcsmith wants to merge 7 commits intoN64Recomp:mainfrom
Open
Move save API from librecomp to ultramodern#137gcsmith wants to merge 7 commits intoN64Recomp:mainfrom
gcsmith wants to merge 7 commits intoN64Recomp:mainfrom
Conversation
Contributor
Author
|
For context, this change is to support adding the ControllerPak logic to ultramodern. It also adds functionality that would be desirable for the fully native mode (e.g., for source ports). Leaving EEPROM / PI / flash migration for a future PR to keep the scope reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some caveats:
librecomp/files.hppis used directly in recomps so this is API breaking. however, I could leave afiles.hppin librecomp that aliases the ultramodern functions in the recomp namespacesave_read_ptrandsave_write_ptrthroughout rather than directly accessing rdramI don't think there's anything stopping us from having a mechanism to perform byte-swapped rdram copies on the ultramodern side, but this sticks to the existing convention of leaving that responsibility to librecomp and using proxies in those cases.