Skip to content

Ability to build with ip and sp library#1197

Merged
scrasmussen merged 1 commit intoNCAR:mainfrom
scrasmussen:enhancement/build-with-ip
Mar 24, 2026
Merged

Ability to build with ip and sp library#1197
scrasmussen merged 1 commit intoNCAR:mainfrom
scrasmussen:enhancement/build-with-ip

Conversation

@scrasmussen
Copy link
Member

Description of Changes:

  • Add ability to build with ip library if it is found. The sp library is being replaced by ip so this is required. Note that in spack-stack the ip package builds with the OpenMP flag so it gets turned on in the CMake build. This means the CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model since the RRTMGP files currently break if compiled with OpenMP flags. The CMAKE_Fortran_FLAGS_OPENMP_OFF environement variable will make sure OpenMP isn't used by the RRTMGP files.

Tests Conducted:

Builds and runs with the SCM, see NCAR/ccpp-scm#662 for tests.

Documentation:

Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? No

Issue (optional):

Partly fixes issue mentioned in #1193,

Contributors (optional):

Built on work from @climbfuji in #1090 and NCAR/ccpp-scm#524

@scrasmussen scrasmussen changed the title Ability to build with ip and sp library Feb 26, 2026
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

…ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags.
@scrasmussen scrasmussen force-pushed the enhancement/build-with-ip branch from d755cd7 to a2fa199 Compare March 24, 2026 15:51
@scrasmussen scrasmussen merged commit 1ab4de8 into NCAR:main Mar 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants