fix(nmr): handle nested arrays when extracting spectra metadata - #1530
Open
vcnainala wants to merge 2 commits into
Open
fix(nmr): handle nested arrays when extracting spectra metadata#1530vcnainala wants to merge 2 commits into
vcnainala wants to merge 2 commits into
Conversation
NMRium info for 2D spectra often stores frequencies, filters, and probe fields as arrays, which caused Array to string conversion during bulk extract.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1530 +/- ##
=================================================
- Coverage 80.34% 80.32% -0.03%
- Complexity 4416 4437 +21
=================================================
Files 289 289
Lines 16241 16284 +43
=================================================
+ Hits 13049 13080 +31
- Misses 3192 3204 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nmrxiv:extract-dataset-spectra-infofrom failing with Array to string conversion on NMRium payloads that store 2D frequencies, filters, meta, or probe fields as arrays.DatasetSpectraInfoExtractorTest.Test plan
php artisan test tests/Unit/Support/DatasetSpectraInfoExtractorTest.phpphp artisan nmrxiv:extract-dataset-spectra-infoand confirm previously failing dataset IDs extract without errorsphp artisan nmrxiv:index-spectra-metadata-stats