You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR makes the necessary changes to the ConMon to support RRFS. Significant changes include:
Drop support for the NAM and some of the time/date calculations that the NAM required. In the NAM the cnvstats for hrs 18z-23z were found in the next day's subdirectory. RRFS puts all the cnvstat files for a given day in the same subdirectory, which simplifies matters.
Modify the GrADS plot scripts for time and vertical plots for regional plots to limit them to a single area (termed global within the code). Most of the subdomains simply don't apply to regional models (e.g. S. America, Europe, etc.).
Add a new utility, find_last_cycle_rgnl.sh for both RadMon and ConMon use with regional sources.
Additionally there are some maintenance changes included:
Modify the GrADS plot scripts for time and vertical plots for global sources to reduce the number of plotted areas when the CONMON_RESTRICT_PLOT_AREAS switch is set to on. This is in an effort to reduce space usage.
Eliminate plotting plotstas_time_bias2.gs and plotstas_time_bias2_ps.gs scripts. The resulting files have not been available on the website for a long time (5+ years at least), and they have not been missed. Not running them saves ~2GB in space. The plot files remain in the repo so they can be used in the future if ever desired.
In RadMon the $NUM_CYCLES used in time series plots has been amended to plot 20 days worth of regional data by default. The global default value remains unchanged.
In RadMon the rm_img_files.pl, a utility script which removes old image files, has been tweaked to reduce the number of days worth of retained images as a space saving measure.
Testing has been done with both RRFS and GFS data on wcoss2.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Incorrect cycle intervals skip regional samples and prevent global plots, while extraction failures can be reported as success and cycle discovery can miss available data.
This read leaves area.txt open at EOF, so the region loop's later read of the recreated pathname fails and gives the first plotted region an unknown area label. Close the file after reading $AREA so the loop can reopen it for the region description. Apply the same fix in plotstas_time_bias.gs:34, plotstas_time_count_ps.gs:35, and plotstas_time_bias_ps.gs:34; for the surface-pressure scripts, this affects every regional plot.
Newest empty cycle directory hides earlier populated data
ush/find_last_cycle_rgnl.sh:81
Selecting only the newest directory hides earlier available cycles when that day has no statistics yet, such as during an in-progress or failed first extraction. ConMon_IG.sh then receives an empty timestamp and cannot plot the available data. Skip directories without matching cycle files and select the newest populated one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the necessary changes to the ConMon to support RRFS. Significant changes include:
find_last_cycle_rgnl.shfor both RadMon and ConMon use with regional sources.Additionally there are some maintenance changes included:
CONMON_RESTRICT_PLOT_AREASswitch is set to on. This is in an effort to reduce space usage.plotstas_time_bias2.gsandplotstas_time_bias2_ps.gsscripts. The resulting files have not been available on the website for a long time (5+ years at least), and they have not been missed. Not running them saves ~2GB in space. The plot files remain in the repo so they can be used in the future if ever desired.$NUM_CYCLESused in time series plots has been amended to plot 20 days worth of regional data by default. The global default value remains unchanged.rm_img_files.pl, a utility script which removes old image files, has been tweaked to reduce the number of days worth of retained images as a space saving measure.Testing has been done with both RRFS and GFS data on wcoss2.
Closes #229