🎨 Palette: Add missing tooltips to icon-only buttons#49
Conversation
Added missing `.help()` modifiers to the "Add profile" and "Settings" icon-only buttons in `ProfileSidebarViews.swift` and `ContentToolbar.swift` to ensure symmetry with existing `.accessibilityLabel()` modifiers, improving micro-UX on macOS. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughWalkthroughThis PR adds help tooltip accessibility to two icon-only buttons in macOS SwiftUI by applying ChangesIcon-Only Button Help Tooltips
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.Jules/palette.md:
- Line 11: Replace the literal shell placeholder string "$(date +%Y-%m-%d)" in
the heading "## $(date +%Y-%m-%d) - Found instances lacking symmetric
accessibility labels" with a concrete ISO date (YYYY-MM-DD) so the entry shows
an actual date (e.g., "## 2026-06-08 - Found instances lacking symmetric
accessibility labels"); update that heading to use the desired commit date
before finalizing the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 704fff87-8b72-44dd-9d07-8f70b7c0337e
📒 Files selected for processing (3)
.Jules/palette.mdXboxControllerMapper/XboxControllerMapper/Views/MainWindow/ContentToolbar.swiftXboxControllerMapper/XboxControllerMapper/Views/MainWindow/ProfileSidebarViews.swift
| ## 2026-06-06 - Ensure Symmetry in Accessibility and Tooltips for SwiftUI Icon Buttons | ||
| **Learning:** In macOS SwiftUI applications, icon-only buttons often have either `.help()` (for hover tooltips) or `.accessibilityLabel()` (for VoiceOver), but frequently lack both. Both are necessary because they serve different user interaction models—`.help` for visual hover feedback and `.accessibilityLabel` for screen readers. | ||
| **Action:** When adding or reviewing icon-only buttons in SwiftUI, always ensure symmetry by defining both `.help("Description")` and `.accessibilityLabel("Description")` to cover all accessibility and usability vectors. | ||
| ## $(date +%Y-%m-%d) - Found instances lacking symmetric accessibility labels |
There was a problem hiding this comment.
Replace the literal shell placeholder with a concrete date.
$(date +%Y-%m-%d) is committed as plain text, so this entry won’t show an actual date like the rest of the palette history. Use a real ISO date string in the heading.
Suggested fix
-## $(date +%Y-%m-%d) - Found instances lacking symmetric accessibility labels
+## 2026-06-08 - Found instances lacking symmetric accessibility labels📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## $(date +%Y-%m-%d) - Found instances lacking symmetric accessibility labels | |
| ## 2026-06-08 - Found instances lacking symmetric accessibility labels |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.Jules/palette.md at line 11, Replace the literal shell placeholder string
"$(date +%Y-%m-%d)" in the heading "## $(date +%Y-%m-%d) - Found instances
lacking symmetric accessibility labels" with a concrete ISO date (YYYY-MM-DD) so
the entry shows an actual date (e.g., "## 2026-06-08 - Found instances lacking
symmetric accessibility labels"); update that heading to use the desired commit
date before finalizing the change.
1 participant
💡 What: Added
.help("Settings")and.help("Add profile")to their respective icon-only buttons.🎯 Why: While screen readers could read
.accessibilityLabel(), sighted mouse users on macOS had no tooltip hint for these critical icon buttons.♿ Accessibility: Enhanced visual hover discoverability for macOS users while maintaining existing VoiceOver support.
PR created automatically by Jules for task 7678132752822010327 started by @NSEvent
Summary by CodeRabbit
Accessibility