Skip to content

🎨 Palette: Add missing tooltips to list action buttons#52

Merged
NSEvent merged 1 commit into
mainfrom
palette/add-tooltips-to-icon-buttons-10026388861524157399
Jun 12, 2026
Merged

🎨 Palette: Add missing tooltips to list action buttons#52
NSEvent merged 1 commit into
mainfrom
palette/add-tooltips-to-icon-buttons-10026388861524157399

Conversation

@NSEvent

@NSEvent NSEvent commented Jun 10, 2026

Copy link
Copy Markdown
Owner

💡 What: Added .help("...") tooltips to the icon-only action buttons (Edit, Delete, Clear) in list rows for Gestures, Chords, and Sequences.
🎯 Why: To make the interface more intuitive and resolve the ambiguity of relying solely on iconography. This follows the accessibility standards of having both a visual tooltip (via .help) and VoiceOver text (via .accessibilityLabel).
Accessibility: Ensures sighted mouse users have the same contextual information that was previously only available to VoiceOver users.


PR created automatically by Jules for task 10026388861524157399 started by @NSEvent

Summary by CodeRabbit

  • Bug Fixes
    • Added helpful tooltips to action buttons (Edit, Delete, and Clear) across the interface for improved accessibility and button discoverability.

Add `.help()` modifiers to icon-only buttons (Edit, Delete, Clear) in `GestureListViews.swift` and `ChordSequenceListViews.swift`. This ensures symmetry with existing `.accessibilityLabel` modifiers, improving usability for sighted mouse users while maintaining screen reader accessibility.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: badb94da-3a71-4120-a187-a0e1ecb5cc34

📥 Commits

Reviewing files that changed from the base of the PR and between 4cb2827 and 1a6b2a8.

📒 Files selected for processing (2)
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordSequenceListViews.swift
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/GestureListViews.swift

📝 Walkthrough

Walkthrough

This PR adds SwiftUI .help(...) tooltips to icon-only action buttons (Edit, Delete, Clear) in list row components across three views: ChordRow, SequenceRow, and GestureRow. These tooltip modifiers expose button affordances during keyboard navigation and mouse hover interactions.

Changes

List row action button tooltips

Layer / File(s) Summary
Chord and sequence row action button tooltips
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordSequenceListViews.swift
Edit and Delete buttons in ChordRow and SequenceRow now display .help("Edit") and .help("Delete") tooltips respectively, improving discoverability of these icon-only buttons.
Gesture row action button tooltips
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/GestureListViews.swift
Edit and Clear buttons in GestureRow now display .help("Edit") and .help("Clear") tooltips respectively, applying the same accessibility improvement pattern.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NSEvent/xbox-controller-mapper#45: Adds .help(...) tooltips and .accessibilityLabel(...) to icon-only buttons in QuickTextRowView, AppBarItemRowView, and WebsiteLinkRowView using the same accessibility pattern.
  • NSEvent/xbox-controller-mapper#42: Adds .help("...") tooltips to icon-only edit and delete buttons in macro and script list row views, following the same accessibility improvement approach.
  • NSEvent/xbox-controller-mapper#49: Adds SwiftUI .help(...) hover tooltips to icon-only buttons in toolbar and sidebar components, expanding the same accessibility pattern across the application.

Poem

🐰 With trembling paws, we add a touch,
A .help() here, a tooltip, much
To guide the keyboard-weary soul—
Edit, Delete, Clear their role!
Hover bright, the buttons speak,
Accessibility, not oblique. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding tooltips to action buttons in list views across multiple components (Chords, Sequences, and Gestures).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/add-tooltips-to-icon-buttons-10026388861524157399

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NSEvent NSEvent merged commit 5d9780a into main Jun 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant