🎨 Palette: Add missing tooltips to list action buttons#52
Conversation
Add `.help()` modifiers to icon-only buttons (Edit, Delete, Clear) in `GestureListViews.swift` and `ChordSequenceListViews.swift`. This ensures symmetry with existing `.accessibilityLabel` modifiers, improving usability for sighted mouse users while maintaining screen reader accessibility. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds SwiftUI ChangesList row action button tooltips
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Added
.help("...")tooltips to the icon-only action buttons (Edit, Delete, Clear) in list rows for Gestures, Chords, and Sequences.🎯 Why: To make the interface more intuitive and resolve the ambiguity of relying solely on iconography. This follows the accessibility standards of having both a visual tooltip (via
.help) and VoiceOver text (via.accessibilityLabel).♿ Accessibility: Ensures sighted mouse users have the same contextual information that was previously only available to VoiceOver users.
PR created automatically by Jules for task 10026388861524157399 started by @NSEvent
Summary by CodeRabbit