Skip to content

🎨 Palette: Add accessibility and tooltips to webhook header buttons#53

Merged
NSEvent merged 1 commit into
mainfrom
palette/add-accessibility-webhook-buttons-1136719797351930065
Jun 12, 2026
Merged

🎨 Palette: Add accessibility and tooltips to webhook header buttons#53
NSEvent merged 1 commit into
mainfrom
palette/add-accessibility-webhook-buttons-1136719797351930065

Conversation

@NSEvent

@NSEvent NSEvent commented Jun 11, 2026

Copy link
Copy Markdown
Owner

💡 What

Added .help() tooltips and .accessibilityLabel() modifiers to the icon-only plus.circle.fill and minus.circle.fill buttons in the Webhook Headers section of ActionMappingEditor.swift and ChordMappingSheet.swift.

🎯 Why

Icon-only buttons used for adding or removing items in a dictionary form were ambiguous to screen readers and lacked hover context for mouse users. This change ensures these interactive elements are clearly communicated to all users, making the dynamic form more accessible and intuitive.

♿ Accessibility

  • Added Remove header label to minus buttons.
  • Added Add header label to plus buttons.

Also updated .Jules/palette.md to document this learning about dynamic form lists.


PR created automatically by Jules for task 1136719797351930065 started by @NSEvent

Summary by CodeRabbit

  • Bug Fixes
    • Added accessibility labels and tooltips to header add/remove buttons for improved screen reader support.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f170f25e-d2cc-43e7-afe2-4b3b41cf2cd7

📥 Commits

Reviewing files that changed from the base of the PR and between c5dbc5f and 340670d.

📒 Files selected for processing (3)
  • .Jules/palette.md
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ActionMappingEditor.swift
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordMappingSheet.swift

📝 Walkthrough

Walkthrough

This PR adds accessibility metadata to icon-only add/remove buttons used for webhook header management across two SwiftUI view controllers. Each button now includes both a .help() hover tooltip and an .accessibilityLabel() for screen reader support.

Changes

Webhook header button accessibility

Layer / File(s) Summary
Accessibility guidance documentation
.Jules/palette.md
New palette entry documents the requirement to add .help(...) tooltips and .accessibilityLabel(...) to icon-only add/remove buttons in dynamic form sections.
ActionMappingEditor webhook header buttons
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ActionMappingEditor.swift
Remove (minus icon) and add (plus icon) header buttons in the webhook headers section each receive .help() text and .accessibilityLabel() for tooltip and screen-reader support.
ChordMappingSheet webhook header buttons
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ChordMappingSheet.swift
Remove and add buttons in the system command webhook header UI each receive matching .help() and .accessibilityLabel() accessibility modifiers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Icon buttons need a voice so clear,
Help text and labels, screen readers hear!
Across two views, the pattern flows,
Accessibility blooms wherever it goes! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding accessibility labels and tooltips to webhook header buttons, which aligns with the actual modifications across all changed files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/add-accessibility-webhook-buttons-1136719797351930065

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@NSEvent NSEvent merged commit e2f4334 into main Jun 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant