Skip to content

🎨 Palette: Ensure symmetry in accessibility and tooltips for icon buttons#56

Open
NSEvent wants to merge 1 commit into
mainfrom
palette/icon-accessibility-tooltips-15089943999790081312
Open

🎨 Palette: Ensure symmetry in accessibility and tooltips for icon buttons#56
NSEvent wants to merge 1 commit into
mainfrom
palette/icon-accessibility-tooltips-15089943999790081312

Conversation

@NSEvent

@NSEvent NSEvent commented Jun 15, 2026

Copy link
Copy Markdown
Owner

💡 What: Added .accessibilityLabel() and .help() modifiers to several icon-only buttons across the app.
🎯 Why: Sighted users rely on tooltips (.help) to understand what an icon button does on hover, while screen reader users rely on VoiceOver to read out an .accessibilityLabel. To ensure an intuitive and accessible experience, both should always be symmetrical on icon-only buttons.
Accessibility: Ensured full accessibility for the "Hide Section" button, the "Copy Code" button, and the "Remove Step" button.


PR created automatically by Jules for task 15089943999790081312 started by @NSEvent

Summary by CodeRabbit

  • Documentation

    • Added guidelines for ensuring consistent accessibility support across icon-only buttons in the interface.
  • Bug Fixes

    • Improved accessibility descriptions for various buttons throughout the app, providing clearer labels for screen readers and better contextual help for all users.

…ly buttons

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9fcfb781-4da8-411b-b286-e137affaeb58

📥 Commits

Reviewing files that changed from the base of the PR and between 3df5442 and 2cedca4.

📒 Files selected for processing (4)
  • .Jules/palette.md
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/ButtonMappingsTab.swift
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/CommunityProfilesSheet.swift
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/SequenceMappingSheet.swift

📝 Walkthrough

Walkthrough

Three SwiftUI icon-only buttons receive missing .accessibilityLabel or .help modifiers: the hide-section button in ButtonMappingsTab, the copy-to-clipboard button in CommunityProfilesSheet, and the remove-step button in SequenceMappingSheet. The .Jules/palette.md guidelines are updated with a dated entry codifying the pairing rule.

Changes

Accessibility and tooltip additions

Layer / File(s) Summary
accessibilityLabel and .help additions in three views
XboxControllerMapper/.../ButtonMappingsTab.swift, XboxControllerMapper/.../CommunityProfilesSheet.swift, XboxControllerMapper/.../SequenceMappingSheet.swift
Hide-section button gains .accessibilityLabel("Hide \(section.label)"), copy-to-clipboard button gains a dynamic label toggling between "Copied" and "Copy code", and the remove-step button gains .help("Remove step").
Palette guideline update
.Jules/palette.md
New dated entry specifying that icon-only SwiftUI buttons must include both .help(...) and .accessibilityLabel(...) for symmetry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NSEvent/xbox-controller-mapper#42: Applies the same .help(...)/.accessibilityLabel(...) pairing pattern to icon-only buttons and shares the .Jules/palette.md guideline basis.
  • NSEvent/xbox-controller-mapper#55: Updates .Jules/palette.md with the identical icon-button accessibility rule and applies the same modifier pattern to SwiftUI controls.
  • NSEvent/xbox-controller-mapper#49: Adds missing .help(...) tooltips to icon-only controls, directly matching the SequenceMappingSheet remove-step fix in this PR.

Poem

🐇 Hop hop, little button, no label to hide,
.accessibilityLabel now sits by your side!
VoiceOver will whisper your purpose out clear,
And .help(...) tooltip will hover right here.
Every icon-only button, aligned and complete —
The palette says so, the guideline is neat! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding accessibility labels and help modifiers to icon-only buttons for symmetry between tooltips and VoiceOver labels.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/icon-accessibility-tooltips-15089943999790081312

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant