refactor: improve type-safe config and NER boundaries#596
Closed
binaryaaron wants to merge 7 commits into
Closed
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
area:dev-ex
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
7 tasks
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
binaryaaron
force-pushed
the
binaryaaron/typing-extensions-enhancements
branch
from
7d9e0b8 to
f615b67
Compare
|
|
||
| def _resolve_config(self, values: ParamDict | NSSParameters | None, cls: type[ParamT], **kwargs) -> ParamT: | ||
| @overload | ||
| def _resolve_config(self, values: ParamT, cls: type[ParamT], **kwargs: object) -> ParamT: ... |
| def _resolve_config(self, values: ParamT, cls: type[ParamT], **kwargs: object) -> ParamT: ... | ||
|
|
||
| @overload | ||
| def _resolve_config(self, values: RawConfig, cls: type[ParamT], **kwargs: object) -> ParamT: ... |
| def _resolve_config(self, values: RawConfig, cls: type[ParamT], **kwargs: object) -> ParamT: ... | ||
|
|
||
| @overload | ||
| def _resolve_config(self, values: None, cls: type[ParamT], **kwargs: object) -> ParamT: ... |
| input_data: str | dict[str, Any] | list[str] | list[dict[str, Any]], | ||
| *, | ||
| timings_only: Literal[True], | ||
| ) -> NERTimingsPayload: ... |
| input_data: str, | ||
| *, | ||
| timings_only: Literal[False] = False, | ||
| ) -> NERPredictionRows: ... |
| input_data: list[str], | ||
| *, | ||
| timings_only: Literal[False] = False, | ||
| ) -> list[list[NERRawPredictionPayload]]: ... |
| input_data: dict[str, Any] | list[dict[str, Any]], | ||
| *, | ||
| timings_only: Literal[False] = False, | ||
| ) -> list[NERApiResponseRow]: ... |
| input_data: str | dict[str, Any] | list[str] | list[dict[str, Any]], | ||
| *, | ||
| timings_only: bool = False, | ||
| ) -> NERModelPredictionResponse | NERTimingsPayload: ... |
| min_score: float = 0.0, | ||
| timings_only: Literal[True], | ||
| include_labels: Optional[set[str]] = None, | ||
| ) -> Timings: ... |
| min_score: float = 0.0, | ||
| timings_only: Literal[False] = False, | ||
| include_labels: Optional[set[str]] = None, | ||
| ) -> PipelineResult: ... |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan