Skip to content

fix: keep deployments backend optional#698

Merged
svvarom merged 2 commits into
mainfrom
fix/automodel-workspace-contract
Jul 15, 2026
Merged

fix: keep deployments backend optional#698
svvarom merged 2 commits into
mainfrom
fix/automodel-workspace-contract

Conversation

@svvarom

@svvarom svvarom commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The Automodel nightly image build fails while validating its reduced uv workspace because nmp-models declares nemo-deployments-plugin as a required workspace dependency even though that backend is loaded lazily. This removes the accidental required edge, refreshes the lockfile, and adds regression coverage for all reduced Docker workspaces so the normal uv sync --package nmp-models path works again.

Failure: Platform-Deploy run 29388161869

This is the root-contract alternative to #697: it keeps dependency resolution enabled instead of installing nmp-models with --no-deps.

Human attention needed

  • Decision: confirm the deployments plugin is optional for nmp-models and should be installed through the platform plugin profile when enabled
  • Read carefully: services/core/models/pyproject.toml and the optional-dependency assertion
  • Safe to skim: the two-line uv.lock update
  • Proof: focused tests, lint/format checks, bake graph, and the exact private Docker build all pass
  • Biggest risk: a consumer may have relied on installing bare nmp-models to pull the deployments plugin implicitly

Evidence

  • uv lock --check
  • pytest tests/unit/test_docker_workspace_slices.py services/core/models/tests/unit/controllers/test_backend_registry.py (5 passed)
  • ruff check and ruff format --check on the new test
  • BUILD_ARCH=linux/amd64 make docker-print TARGET=nmp-automodel-tasks-docker
  • Platform-Deploy run 29429138807 passed the full Automodel, Unsloth, and RL bake plus both Automodel smoke targets against commit 39d915c22a6335d189810e7e22c4990145dc7e89.

@svvarom
svvarom requested review from a team as code owners July 15, 2026 15:38
@github-actions github-actions Bot added the fix label Jul 15, 2026
Signed-off-by: Swarom Muley <smuley@nvidia.com>
@svvarom
svvarom force-pushed the fix/automodel-workspace-contract branch from 7b9e411 to 39d915c Compare July 15, 2026 15:38
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The models service removes nemo-deployments-plugin from unconditional dependencies and workspace sources. New tests validate workspace-source coverage for Docker slices and ensure the deployments plugin remains optional.

Changes

Models workspace dependencies

Layer / File(s) Summary
Remove optional deployments dependency
services/core/models/pyproject.toml
Removes nemo-deployments-plugin from dependencies and tool.uv.sources.
Validate workspace slice consistency
tests/unit/test_docker_workspace_slices.py
Adds helpers and regression tests covering workspace-source membership across Docker slices and the models plugin declaration.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: keeping the deployments backend optional.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/automodel-workspace-contract

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 25439/32661 77.9% 62.5%
Integration Tests 14703/31310 47.0% 19.3%

@svvarom svvarom closed this Jul 15, 2026
@svvarom svvarom reopened this Jul 15, 2026
@svvarom
svvarom enabled auto-merge July 15, 2026 16:12
@svvarom svvarom self-assigned this Jul 15, 2026
@svvarom
svvarom added this pull request to the merge queue Jul 15, 2026
Merged via the queue into main with commit 1525a6c Jul 15, 2026
55 checks passed
@svvarom
svvarom deleted the fix/automodel-workspace-contract branch July 15, 2026 17:05
tylersbray added a commit that referenced this pull request Jul 16, 2026
- Drop nemo-deployments-plugin as an unconditional models dependency; the
  registry loads it lazily, matching main's optional-plugin design (#698).
  Re-sync vendored models-service extra (drop kubernetes/docker) and uv.lock.
- Make the deployments_plugin integration test self-contained instead of
  importing skip_without_docker from a sibling conftest, which collided with
  another service's conftest during full-repo collection.
- Add services/core/models/tests/unit to pytest pythonpath so the
  override_config test can import its nimservice_spec_types helper.
- Revert override_config/k8s_nim_operator_config schema description tweaks and
  regenerate the OpenAPI spec to keep it in sync with the vendored SDK.

Signed-off-by: Tyler Bray <tbray@nvidia.com>
tylersbray added a commit that referenced this pull request Jul 16, 2026
- Drop nemo-deployments-plugin as an unconditional models dependency; the
  registry loads it lazily, matching main's optional-plugin design (#698).
  Re-sync vendored models-service extra (drop kubernetes/docker) and uv.lock.
- Make the deployments_plugin integration test self-contained instead of
  importing skip_without_docker from a sibling conftest, which collided with
  another service's conftest during full-repo collection.
- Add services/core/models/tests/unit to pytest pythonpath so the
  override_config test can import its nimservice_spec_types helper.
- Revert override_config/k8s_nim_operator_config schema description tweaks and
  regenerate the OpenAPI spec to keep it in sync with the vendored SDK.

Signed-off-by: Tyler Bray <tbray@nvidia.com>
tylersbray added a commit that referenced this pull request Jul 16, 2026
- Drop nemo-deployments-plugin as an unconditional models dependency; the
  registry loads it lazily, matching main's optional-plugin design (#698).
  Re-sync vendored models-service extra (drop kubernetes/docker) and uv.lock.
- Make the deployments_plugin integration test self-contained instead of
  importing skip_without_docker from a sibling conftest, which collided with
  another service's conftest during full-repo collection.
- Add services/core/models/tests/unit to pytest pythonpath so the
  override_config test can import its nimservice_spec_types helper.
- Revert override_config/k8s_nim_operator_config schema description tweaks and
  regenerate the OpenAPI spec to keep it in sync with the vendored SDK.

Signed-off-by: Tyler Bray <tbray@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants