fix: keep deployments backend optional#698
Merged
Merged
Conversation
Signed-off-by: Swarom Muley <smuley@nvidia.com>
svvarom
force-pushed
the
fix/automodel-workspace-contract
branch
from
July 15, 2026 15:38
7b9e411 to
39d915c
Compare
Contributor
📝 WalkthroughWalkthroughThe models service removes ChangesModels workspace dependencies
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
mckornfield
approved these changes
Jul 15, 2026
svvarom
enabled auto-merge
July 15, 2026 16:12
tylersbray
added a commit
that referenced
this pull request
Jul 16, 2026
- Drop nemo-deployments-plugin as an unconditional models dependency; the registry loads it lazily, matching main's optional-plugin design (#698). Re-sync vendored models-service extra (drop kubernetes/docker) and uv.lock. - Make the deployments_plugin integration test self-contained instead of importing skip_without_docker from a sibling conftest, which collided with another service's conftest during full-repo collection. - Add services/core/models/tests/unit to pytest pythonpath so the override_config test can import its nimservice_spec_types helper. - Revert override_config/k8s_nim_operator_config schema description tweaks and regenerate the OpenAPI spec to keep it in sync with the vendored SDK. Signed-off-by: Tyler Bray <tbray@nvidia.com>
7 tasks
tylersbray
added a commit
that referenced
this pull request
Jul 16, 2026
- Drop nemo-deployments-plugin as an unconditional models dependency; the registry loads it lazily, matching main's optional-plugin design (#698). Re-sync vendored models-service extra (drop kubernetes/docker) and uv.lock. - Make the deployments_plugin integration test self-contained instead of importing skip_without_docker from a sibling conftest, which collided with another service's conftest during full-repo collection. - Add services/core/models/tests/unit to pytest pythonpath so the override_config test can import its nimservice_spec_types helper. - Revert override_config/k8s_nim_operator_config schema description tweaks and regenerate the OpenAPI spec to keep it in sync with the vendored SDK. Signed-off-by: Tyler Bray <tbray@nvidia.com>
tylersbray
added a commit
that referenced
this pull request
Jul 16, 2026
- Drop nemo-deployments-plugin as an unconditional models dependency; the registry loads it lazily, matching main's optional-plugin design (#698). Re-sync vendored models-service extra (drop kubernetes/docker) and uv.lock. - Make the deployments_plugin integration test self-contained instead of importing skip_without_docker from a sibling conftest, which collided with another service's conftest during full-repo collection. - Add services/core/models/tests/unit to pytest pythonpath so the override_config test can import its nimservice_spec_types helper. - Revert override_config/k8s_nim_operator_config schema description tweaks and regenerate the OpenAPI spec to keep it in sync with the vendored SDK. Signed-off-by: Tyler Bray <tbray@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Automodel nightly image build fails while validating its reduced uv workspace because
nmp-modelsdeclaresnemo-deployments-pluginas a required workspace dependency even though that backend is loaded lazily. This removes the accidental required edge, refreshes the lockfile, and adds regression coverage for all reduced Docker workspaces so the normaluv sync --package nmp-modelspath works again.Failure: Platform-Deploy run 29388161869
This is the root-contract alternative to #697: it keeps dependency resolution enabled instead of installing
nmp-modelswith--no-deps.Human attention needed
nmp-modelsand should be installed through the platform plugin profile when enabledservices/core/models/pyproject.tomland the optional-dependency assertionuv.lockupdatenmp-modelsto pull the deployments plugin implicitlyEvidence
uv lock --checkpytest tests/unit/test_docker_workspace_slices.py services/core/models/tests/unit/controllers/test_backend_registry.py(5 passed)ruff checkandruff format --checkon the new testBUILD_ARCH=linux/amd64 make docker-print TARGET=nmp-automodel-tasks-docker39d915c22a6335d189810e7e22c4990145dc7e89.