fix(agents): resolve default model in SDK-created agents#789
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughChangesAgent SDK and deployment documentation
Sequence Diagram(s)sequenceDiagram
participant Caller
participant AgentsResource
participant inject_default_model
participant AgentAPI
Caller->>AgentsResource: create(config)
AgentsResource->>inject_default_model: resolve default model
inject_default_model-->>AgentsResource: resolved config
AgentsResource->>AgentAPI: POST resolved agent config
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/requirements.mdx`:
- Line 32: Update the “Image access” requirement in docs/requirements.mdx to
distinguish NGC credentials for API/model-download access from imagePullSecrets
for private registry or mirror pulls. Do not present both as jointly required
for pulling NeMo Platform images; state each requirement independently according
to its scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1f646c0b-c877-4fe0-a86d-e02cd807ece3
📒 Files selected for processing (5)
docs/agents/deploy-agents.mdxdocs/requirements.mdxdocs/support-matrix.mdxplugins/nemo-agents/src/nemo_agents_plugin/sdk.pyplugins/nemo-agents/tests/unit/test_sdk.py
Contributor
|
anastasia-nesterenko
approved these changes
Jul 20, 2026
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
mckornfield
force-pushed
the
6480318-k8s-agent-docs/mkornfield
branch
from
July 20, 2026 21:39
b47ae53 to
0ec2151
Compare
mckornfield
enabled auto-merge
July 20, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
${NEMO_DEFAULT_MODEL}, which is resolved when creating agents via the SDK/CLI.Bug Fixes
${NEMO_DEFAULT_MODEL}cannot be resolved.Documentation
${NEMO_DEFAULT_MODEL}placeholder with an explicit VirtualModel name.Tests