fix: pillow updates and others for images - #817
Conversation
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
📝 WalkthroughWalkthroughDocker images now constrain Pillow to version 12.x, remove inherited Pillow artifacts, reinstall it where required, and upgrade selected Ubuntu packages in the NeMo-RL base image. ChangesContainer dependency and image hardening
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docker/Dockerfile.nmp-rl-base (1)
31-34: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winAdd
--no-install-recommends.This avoids pulling unnecessary packages into the hardened base image and reduces image size and vulnerability surface.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/Dockerfile.nmp-rl-base` around lines 31 - 34, Add the --no-install-recommends option to the apt-get install command in Dockerfile.nmp-rl-base, while preserving the existing package upgrades and cleanup behavior.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docker/Dockerfile.nmp-rl-base`:
- Around line 31-34: Add the --no-install-recommends option to the apt-get
install command in Dockerfile.nmp-rl-base, while preserving the existing package
upgrades and cleanup behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e91959ae-71ec-4ba8-98e5-9279ca0a2ca3
📒 Files selected for processing (5)
docker/Dockerfile.nmp-customizer-tasksdocker/Dockerfile.nmp-rl-basedocker/Dockerfile.nmp-rl-trainingdocker/Dockerfile.nmp-unsloth-trainingdocker/automodel/Dockerfile.nmp-automodel-base
|
Summary by CodeRabbit