chore: upgrade containers to python 3.13#858
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughPython Docker builds now accept a configurable Python version, use matching base images and virtual environments, and place runtime assets in version-specific site-packages paths. Docker Bake forwards the parameter to Python base, API, and core targets. ChangesPython Docker Configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker-bake.hcl`:
- Around line 39-45: Update the docker-bake.hcl configuration around
NMP_PYTHON_IMAGE, NMP_PYTHON_VERSION, and python_base_target() so the selected
base image and interpreter version cannot drift. Prefer deriving the Python
version from the image or add a build-time validation that rejects mismatches
before building, ensuring the venv layout and policy.wasm destination remain
aligned with the active site-packages path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 23829f6d-90c5-4ad6-825e-c22fa35d6af4
📒 Files selected for processing (4)
docker-bake.hcldocker/Dockerfile.nmp-apidocker/Dockerfile.nmp-coredocker/base/Dockerfile.nmp-python-base
f3bb22f to
5ed7b22
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker-bake.hcl`:
- Around line 39-42: Define an NMP_PYTHON_IMAGE bake variable with default
python:3.13.14-slim-trixie, and update all four base targets to use this
variable unchanged instead of constructing an image from NMP_PYTHON_VERSION.
Preserve NMP_PYTHON_VERSION only where independently needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 70019ad1-74ec-41e7-9901-da6e66895740
📒 Files selected for processing (4)
docker-bake.hcldocker/Dockerfile.nmp-apidocker/Dockerfile.nmp-coredocker/base/Dockerfile.nmp-python-base
🚧 Files skipped from review as they are similar to previous changes (3)
- docker/Dockerfile.nmp-core
- docker/Dockerfile.nmp-api
- docker/base/Dockerfile.nmp-python-base
|
400aac0 to
5b07885
Compare
006fd86 to
228eb33
Compare
Signed-off-by: Ryan S <267728323+ironcommit@users.noreply.github.com>
228eb33 to
c5045ce
Compare
Signed-off-by: Ryan S <267728323+ironcommit@users.noreply.github.com>
Summary
Upgrades the container build infrastructure from a hardcoded Python 3.11 base image to Python 3.13, making the Python version configurable via build arguments.
Changes
docker/base/Dockerfile.nmp-python-base: Replace hardcodedpython:3.11.15-slim-bookwormbase image with a configurableNMP_PYTHON_IMAGEarg (defaulting topython:3.13.14-slim-trixie). Theuv venvcall now usesNMP_PYTHON_VERSIONinstead of a hardcoded3.11.docker/Dockerfile.nmp-apianddocker/Dockerfile.nmp-core: Parameterize thepolicy.wasmCOPY path to useNMP_PYTHON_VERSIONinstead of hardcodedpython3.11, so the asset is placed in the correctsite-packagesdirectory for the selected interpreter.docker-bake.hcl: AddNMP_PYTHON_IMAGEandNMP_PYTHON_VERSIONvariables and pass them to all base image targets (nmp-python-base,nmp-python-dev-base, and their builder variants) as well asnmp-api-dockerandnmp-core-docker.Notes
NMP_PYTHON_IMAGEandNMP_PYTHON_VERSIONin the bake invocation.Summary by CodeRabbit
New Features
Bug Fixes
Maintenance