Skip to content

ci: stage nightly wheels without publishing#877

Merged
svvarom merged 2 commits into
mainfrom
stage-nightly-wheels-only/smuley
Jul 24, 2026
Merged

ci: stage nightly wheels without publishing#877
svvarom merged 2 commits into
mainfrom
stage-nightly-wheels-only/smuley

Conversation

@svvarom

@svvarom svvarom commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Nightly wheels should stop after staging for now. This sets the publishing flag to false, skips public-index polling, and reports wheel staging as dispatched. Stable wheels, containers, and Helm are unchanged.

Validation:

  • actionlint
  • act: wheel-only nightly sends false, skips public wheel polling, and reports wheel staging
  • focused pre-commit hooks

@github-actions github-actions Bot added the ci label Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 27157/34869 77.9% 62.1%
Integration Tests 15969/33581 47.5% 20.0%

@svvarom
svvarom force-pushed the stage-nightly-wheels-only/smuley branch from 4876a38 to 4e9be69 Compare July 23, 2026 23:20
@svvarom
svvarom marked this pull request as ready for review July 23, 2026 23:37
@svvarom
svvarom requested review from a team as code owners July 23, 2026 23:37
@svvarom
svvarom requested a review from crookedstorm July 23, 2026 23:38
Signed-off-by: Swarom Muley <smuley@nvidia.com>
@svvarom
svvarom force-pushed the stage-nightly-wheels-only/smuley branch from 4e9be69 to b4d2e56 Compare July 23, 2026 23:39
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Nightly wheel releases can now be staged internally or published publicly using RELEASE_PUBLISH_NIGHTLY_WHEELS. Dispatching, PyPI polling, Slack notifications, and release documentation reflect the selected behavior.

Changes

Nightly wheel release handling

Layer / File(s) Summary
Wheel dispatch and polling gate
.github/workflows/release.yaml
The workflow forwards the nightly publishing flag to wheel builds and polls PyPI for nightly wheels only when publication is enabled.
Release Slack status reporting
.github/workflows/release.yaml
Slack notifications distinguish published artifacts from staged nightly wheels, conditionally report published artifacts, and update nightly completion messaging.
Release workflow documentation
RELEASING.md
Documentation describes internal nightly wheel staging, public artifact polling, the staging destination, and stable-release verification.

Sequence Diagram(s)

sequenceDiagram
  participant ReleaseWorkflow
  participant Slack
  participant WheelBuildWorkflow
  participant PyPI
  ReleaseWorkflow->>Slack: announce wheel staging or publishing
  ReleaseWorkflow->>WheelBuildWorkflow: dispatch wheel build with publish_nightly_wheels
  WheelBuildWorkflow-->>ReleaseWorkflow: complete wheel build
  ReleaseWorkflow->>PyPI: poll nightly wheels only when publishing is enabled
  ReleaseWorkflow->>Slack: report published artifacts or staging dispatched
Loading

Possibly related PRs

Suggested reviewers: crookedstorm, steramae-nvidia

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: nightly wheels are staged instead of published.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stage-nightly-wheels-only/smuley

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
RELEASING.md (1)

153-157: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add the required Next Steps section.

Add cross-links after the verification guidance. As per coding guidelines, documentation pages must end with a Next Steps section.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@RELEASING.md` around lines 153 - 157, Add a final “Next Steps” section to
RELEASING.md after the stable wheel verification guidance, including the
required cross-links to relevant follow-up documentation. Ensure this section is
the document’s ending content and follows the repository’s standard
documentation structure.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@RELEASING.md`:
- Around line 94-97: Update the release workflow description around the
final-artifact polling step to make nightly wheel handling conditional on
RELEASE_PUBLISH_NIGHTLY_WHEELS. Describe that the enabled mode polls and
publicly publishes nightly wheels, while the disabled mode stages them
internally without polling, preserving the existing timeout and Slack-alert
details.

---

Nitpick comments:
In `@RELEASING.md`:
- Around line 153-157: Add a final “Next Steps” section to RELEASING.md after
the stable wheel verification guidance, including the required cross-links to
relevant follow-up documentation. Ensure this section is the document’s ending
content and follows the repository’s standard documentation structure.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 44ec8252-ee16-4261-8c55-dee7ff509e8f

📥 Commits

Reviewing files that changed from the base of the PR and between 565a815 and 4e9be69.

📒 Files selected for processing (2)
  • .github/workflows/release.yaml
  • RELEASING.md

Comment thread RELEASING.md

@crookedstorm crookedstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. I presume you tested?

@svvarom
svvarom enabled auto-merge July 24, 2026 00:49
@svvarom
svvarom disabled auto-merge July 24, 2026 00:49
@svvarom
svvarom added this pull request to the merge queue Jul 24, 2026
@svvarom

svvarom commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

This looks right. I presume you tested?

yep tested it locally

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 24, 2026
@svvarom
svvarom enabled auto-merge July 24, 2026 04:00
@svvarom
svvarom added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 91cc8d6 Jul 24, 2026
57 checks passed
@svvarom
svvarom deleted the stage-nightly-wheels-only/smuley branch July 24, 2026 04:29
AnuradhaKaruppiah pushed a commit to AnuradhaKaruppiah/nemo-platform that referenced this pull request Jul 24, 2026
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants