ci: stage nightly wheels without publishing#877
Conversation
|
4876a38 to
4e9be69
Compare
Signed-off-by: Swarom Muley <smuley@nvidia.com>
4e9be69 to
b4d2e56
Compare
📝 WalkthroughWalkthroughNightly wheel releases can now be staged internally or published publicly using ChangesNightly wheel release handling
Sequence Diagram(s)sequenceDiagram
participant ReleaseWorkflow
participant Slack
participant WheelBuildWorkflow
participant PyPI
ReleaseWorkflow->>Slack: announce wheel staging or publishing
ReleaseWorkflow->>WheelBuildWorkflow: dispatch wheel build with publish_nightly_wheels
WheelBuildWorkflow-->>ReleaseWorkflow: complete wheel build
ReleaseWorkflow->>PyPI: poll nightly wheels only when publishing is enabled
ReleaseWorkflow->>Slack: report published artifacts or staging dispatched
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
RELEASING.md (1)
153-157: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd the required
Next Stepssection.Add cross-links after the verification guidance. As per coding guidelines, documentation pages must end with a
Next Stepssection.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@RELEASING.md` around lines 153 - 157, Add a final “Next Steps” section to RELEASING.md after the stable wheel verification guidance, including the required cross-links to relevant follow-up documentation. Ensure this section is the document’s ending content and follows the repository’s standard documentation structure.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@RELEASING.md`:
- Around line 94-97: Update the release workflow description around the
final-artifact polling step to make nightly wheel handling conditional on
RELEASE_PUBLISH_NIGHTLY_WHEELS. Describe that the enabled mode polls and
publicly publishes nightly wheels, while the disabled mode stages them
internally without polling, preserving the existing timeout and Slack-alert
details.
---
Nitpick comments:
In `@RELEASING.md`:
- Around line 153-157: Add a final “Next Steps” section to RELEASING.md after
the stable wheel verification guidance, including the required cross-links to
relevant follow-up documentation. Ensure this section is the document’s ending
content and follows the repository’s standard documentation structure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 44ec8252-ee16-4261-8c55-dee7ff509e8f
📒 Files selected for processing (2)
.github/workflows/release.yamlRELEASING.md
crookedstorm
left a comment
There was a problem hiding this comment.
This looks right. I presume you tested?
yep tested it locally |
Signed-off-by: Swarom Muley <smuley@nvidia.com>
Nightly wheels should stop after staging for now. This sets the publishing flag to
false, skips public-index polling, and reports wheel staging as dispatched. Stable wheels, containers, and Helm are unchanged.Validation:
actionlintact: wheel-only nightly sendsfalse, skips public wheel polling, and reports wheel staging