Repository navigation
Conversation
… metadata["embedding"]
to_client_vdb_records now emits {document_type, embedding, metadata}; LanceDB,
collection writes, and the canonical-record check read record["embedding"].
MetadataSchema drops its unused embedding field; docs and the custom VDB
notebook follow.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2794. Graph rows already carry one typed
embeddingcolumn; this removes the last nested copy point: client VDB records now hold the vector at the top level.Scope (breaking):
to_client_vdb_recordswritesrecord["embedding"]; readerslancedb._create_lancedb_result,lancedb_collections._collection_rows, and the missing-embedding check into_client_vdb_recordsread only that. No fallback tometadata["embedding"]; code that builds records by hand forLanceDB.runmust move the vector.MetadataSchema.embeddingis removed.vdbs.md,content-metadata.md) andexamples/building_vdb_operator.ipynbupdated; test fixtures moved to the new shape.Unchanged: values stored in LanceDB (
vectorcolumn, float32), graph-row columns, retrieval.Tests: VDB / LanceDB / service / ingest / records / embedding-input suites: 1680 passed, 8 skipped (CPU-only). black 25.9.0 and flake8 7.3.0 clean on touched files.
Link to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/34802976322840ce95c617ad48813bcd
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/34802976322840ce95c617ad48813bcd?variant=devin
Requested by: @jioffe502