Generate numeric_limits for floating points from __fp_meow machinery
#6550
+311
−1,016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebayer
force-pushed
the
extend_fp_constants
branch
from
cf6ddbb to
534847e
Compare
davebayer
force-pushed
the
extend_fp_constants
branch
from
534847e to
624f99e
Compare
This comment has been minimized.
This comment has been minimized.
fbusato
requested changes
Nov 7, 2025
Contributor
fbusato
left a comment
fbusato
left a comment
There was a problem hiding this comment.
the PR removes several lines from numeric_limits.h and delete numeric_limits_ext.h, which is great! On the other hand, many times we use numeric_limits without the need of extended types. Would not be better to separate the implementations?
| } | ||
|
|
||
| static constexpr bool is_iec559 = true; | ||
| static constexpr int radix = 2; |
Contributor
There was a problem hiding this comment.
should we not add at least a static_assert for FLT_RADIX?
| } | ||
|
|
||
| static constexpr int min_exponent = __fp_exp_min_v<__fmt> + 1; | ||
| static constexpr int min_exponent10 = (30103ll * __fp_exp_min_v<__fmt>) / 100000ll; |
Contributor
There was a problem hiding this comment.
please comment magic numbers
| using namespace test_integer_literals; | ||
|
|
||
| // 1. Test formats | ||
| test_fp_epsilon<cuda::std::__fp_format::__binary16>(0x1400u); |
Contributor
There was a problem hiding this comment.
would not be better to compute the epsilon instead of fixed value? e.g. (1 + "last_bit") - 1
Contributor
😬 CI Workflow Results🟥 Finished in 3h 01m: Pass: 44%/90 | Total: 3d 06h | Max: 3h 00m | Hits: 32%/57911See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
numeric_limitsimplementation for floating point types by reusing our already existing__fp_meowmachinery.