Replace internal uses of thrust::tuple with cuda::std::tuple
#6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
| //! | ||
| //! // finally, create the zip_iterator | ||
| //! ZipIterator iter(thrust::make_tuple(int_v.begin(), float_v.begin(), char_v.begin())); | ||
| //! ZipIterator iter(::cuda::std::make_tuple(int_v.begin(), float_v.begin(), char_v.begin())); |
Contributor
There was a problem hiding this comment.
Suggested change
| //! ZipIterator iter(::cuda::std::make_tuple(int_v.begin(), float_v.begin(), char_v.begin())); | |
| //! ZipIterator iter(cuda::std::make_tuple(int_v.begin(), float_v.begin(), char_v.begin())); |
documentation
miscco
force-pushed
the
drop_thrust_tuple
branch
from
8421522 to
7215eb3
Compare
miscco
force-pushed
the
drop_thrust_tuple
branch
from
7215eb3 to
703e394
Compare
bernhardmgruber
approved these changes
Nov 18, 2025
miscco
force-pushed
the
drop_thrust_tuple
branch
from
703e394 to
2320a0b
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 7h 24m: Pass: 100%/158 | Total: 4d 22h | Max: 4h 59m | Hits: 79%/187258See results here. |
Contributor
|
It seems MatX is missing some includes for the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its an alias anyway and we should be explicit in our uses internally