Use wrapper with void* argument types for iterator advance/dereference signature
#6634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
shwina
force-pushed
the
fix-iterator-signatures-void-star
branch
from
3cef9d0 to
aaeb15b
Compare
Contributor
Author
|
/ok to test aaeb15b |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test 506b362 |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test 4334c15 |
This comment has been minimized.
This comment has been minimized.
c/parallel/test/test_merge_sort.cpp
Outdated
Comment on lines
435
to
438
| "extern \"C\" __device__ void advance(void* state, const void* offset) {\n" | ||
| " auto* typed_state = static_cast<random_access_iterator_state_t*>(state);\n" | ||
| " auto offset_val = *static_cast<const unsigned long long*>(offset);\n" | ||
| " typed_state->d_input += offset_val;\n" |
Contributor
There was a problem hiding this comment.
Question: why not use a raw string literal?
Contributor
Author
There was a problem hiding this comment.
We can. Changed to using raw strings in ac41501.
shwina
force-pushed
the
fix-iterator-signatures-void-star
branch
from
4334c15 to
ac41501
Compare
NaderAlAwar
approved these changes
Nov 18, 2025
Comment on lines
153
to
163
| def get_input_dereference_signature(self): | ||
| return ( | ||
| self.state_ptr_type, | ||
| types.CPointer(self.value_type), | ||
| ) | ||
|
|
||
| def get_output_dereference_signature(self): | ||
| return ( | ||
| self.state_ptr_type, | ||
| self.value_type, | ||
| ) |
Contributor
There was a problem hiding this comment.
Important: let us delete these if they are no longer used
|
|
||
| # Create transform output iterator | ||
| d_out_it = TransformIterator(d_output, sqrt) | ||
| d_out_it = TransformOutputIterator(d_output, sqrt) |
Contributor
There was a problem hiding this comment.
Question: why is this change needed now?
Contributor
Author
There was a problem hiding this comment.
No idea, and honestly no idea how this ever worked before...
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 26m: Pass: 100%/56 | Total: 15h 41m | Max: 1h 22m | Hits: 100%/1240See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge after #6353.
Closes #4573. This PR is shown to resolve issues due to ODR violation, by unmarking a test that was previously marked
xfail.Checklist