Guard unsupported NVML clock-domain queries in tests - #2651
Merged
Conversation
Treat per-domain clock queries as independently optional. Individual domains may reject minimum, maximum, or current clock queries even on newer devices.
rwgk
added
P0
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test d76502a |
This comment has been minimized.
This comment has been minimized.
rwgk
marked this pull request as ready for review
August 17, 2026 01:54
rwgk
enabled auto-merge (squash)
August 17, 2026 03:08
mdboom
approved these changes
Aug 17, 2026
|
2 tasks
2 tasks
leofang
added a commit
that referenced
this pull request
Sep 2, 2026
* Prepare cuda.core v1.2.0 release Fill remaining user-visible entries in the 1.2.0 release notes and add 1.1.1 and 1.2.0 to the docs version switcher. Version is derived from the git tag via setuptools-scm, so no pyproject.toml bump is needed. New features documented: - ProgramOptions.use_bundled_headers for NVRTC 13.3+ (#2753 closes #2363) - cuda-gdb source display for JIT-compiled kernels (#2678, #2679) Fixes and enhancements documented: - PinnedMemoryResource host-pool validation at construction (#2487) - is_host_accessible for NUMA-located VMM (#2503) - Graph predecessor/successor query truncation on large graphs (#2587) - Per-domain NVML clock queries treated as independently optional (#2651) - Temperature threshold checks forward-compat with unknown archs (#2488) - import cuda.core non-integer opt-out crash (#2535) - Frozen CUresult explanation table refreshed for CUDA 13.3 (#2383) -- Leo's bot * Update cuda_core/docs/source/release/1.2.0-notes.rst Co-authored-by: Michael Droettboom <mdboom@gmail.com> --------- Co-authored-by: Michael Droettboom <mdboom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from ctk-next 13.4 developments (PRs 523, 525) after broader platform testing exposed clock domains for which individual NVML queries are unsupported.
Guard the per-domain minimum/maximum and current-clock queries independently with the existing
unsupported_beforehelper. GPU architecture generation alone is not sufficient to predict support for every clock-domain query.Validation
test_clockrun:2 passed,2 skipped, and3 subtests passed.pre-commit run --all-filespasses.Checklist