cmake: include GNUInstallDirs before install interface paths#345
Open
fallintoplace wants to merge 1 commit into
Open
cmake: include GNUInstallDirs before install interface paths#345fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesCMake Include Reorganization
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment Warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CMAKE_INSTALL_INCLUDEDIRcould be empty when used intarget_include_directories()beforeGNUInstallDirsis included, causing invalid installed include paths for package consumers.What changed
include(GNUInstallDirs)to immediately afterproject()soCMAKE_INSTALL_LIBDIR,CMAKE_INSTALL_BINDIR, andCMAKE_INSTALL_INCLUDEDIRare defined before any usage.Validation
No tests were run per request.
Summary by CodeRabbit