cmake: switch python linker flags to target_link_options - #346
Open
fallintoplace wants to merge 1 commit into
Open
cmake: switch python linker flags to target_link_options#346fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change modifies python/CMakeLists.txt to move linker flag configuration for the _compiled_module target from the LINK_FLAGS property in set_target_properties to a dedicated target_link_options call, preserving the same flag values. ChangesCMake linker configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
_compiled_modulesetLINK_FLAGSthree times inset_target_properties, which means earlier values can be overwritten and final exported flags may miss required linker options.What changed
LINK_FLAGSassignments with a singletarget_link_options(_compiled_module PRIVATE ...)call.LINK_WHAT_YOU_USEin its existingset_target_properties(...)call.Verification
cmakeconfigure/build in this environment is blocked by missing CUDA (nvccnot found).Please validate with:
Confirm the verbose link line contains all three flags:
-Wl,--no-as-needed-Wl,--enable-new-dtags-Wl,-rpath,\x27$ORIGIN\x27,-rpath,\x27$ORIGIN/../lib\x27,-rpath,\x27$ORIGIN/../nvidia/cudnn/lib\x27Summary by CodeRabbit