Skip to content

Make run_spotless.sh more verbose and strict - #2485

Open
imotov wants to merge 1 commit into
NVIDIA:mainfrom
imotov:make-java-spotless-fmt-stricter
Open

Make run_spotless.sh more verbose and strict#2485
imotov wants to merge 1 commit into
NVIDIA:mainfrom
imotov:make-java-spotless-fmt-stricter

Conversation

@imotov

@imotov imotov commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Some developers ran into issues with spotless-fmt skipping formatting silently on their local machines and then failing in CI. This PR now fails if there are any modified Java files and prints a warning if there are no changed Java files and Maven is not present.

Follow-up for #2361

Some developers ran into issues with spotless-fmt skipping formatting silently on their local machines and then failing in CI. This PR now fails if there are any modified Java files and prints a warning if there are no changed Java files and Maven is not present.
@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@imotov imotov added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 18, 2026
@imotov

imotov commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 7f33e33

Comment thread ci/checks/run_spotless.sh
Comment thread ci/checks/run_spotless.sh
@imotov imotov self-assigned this Aug 19, 2026
@imotov
imotov marked this pull request as ready for review August 19, 2026 05:39
@imotov
imotov requested review from a team as code owners August 19, 2026 05:39
@imotov
imotov requested a review from bdice August 19, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants