chore(core): cover native popover controller edge paths - #325
Open
cursor[bot] wants to merge 1 commit into
Open
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Adds unit tests for disconnect-before-update, show-popover command, empty interest delay, and legacy hint mouseleave. Line coverage rose from 96.89% to 99.37% and branches from 88.33% to 91.66%. No public API or behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/elements/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected task
coverage for
projects/core/src/internal/controllers/type-native-popover.controller.ts.Selector rationale: "5 uncovered lines, 96.89% lines and 88.33% branches, the smallest gap below the 90% threshold".
Measurement
Added tests in the existing
type-native-popover.controller.test.tsfor:hostConnectedsetup when the element disconnects before the first updateshow-popoverinvoker commandopenDelayand empty computedinterestDelayStartmouseleaveand rebinding listeners when the trigger changesPublic API
No public API changed. No production source changed. Behavior is unchanged.
Left alone
Line 203 (
#removeHintTriggerwhen#hintTriggeralready differs from the new trigger after#clearLegacyTrigger) remains uncovered. That branch is defensive after the hint path already clears the previous trigger. CSS.escape fallbacks and millisecond-unit interest delay parsing were not added, to stay inside the 150-line cap.Diff: 1 file, +98 lines.