Skip to content

feat(tui): Support full-mesh VPC peering - #5515

Draft
kfelternv wants to merge 1 commit into
NVIDIA:mainfrom
kfelternv:feat-vpc-full-mesh
Draft

feat(tui): Support full-mesh VPC peering#5515
kfelternv wants to merge 1 commit into
NVIDIA:mainfrom
kfelternv:feat-vpc-full-mesh

Conversation

@kfelternv

Copy link
Copy Markdown
Contributor

nicocli's TUI can only create one VPC peering at a time. This change adds a guided two-or-more-VPC selection that previews and creates the full mesh, skips existing pairs, and reports created, skipped, and failed pairs.

Related issues

Closes #5460

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Focused cli/tui tests pass with race detection; revision-scoped golangci-lint is clean.

Additional Notes

The full cli/tui suite retains two pre-existing nvlink-domain selector-policy failures reproduced at the exact base commit.

Signed-off-by: Kyle Felter <kfelter@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@kfelternv
kfelternv requested a review from thossain-nv August 28, 2026 15:37
@thossain-nv thossain-nv added the rest-api Add this label when an issue or PR concerns NICo REST API label Aug 28, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rest-api Add this label when an issue or PR concerns NICo REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nicocli TUI: support full-mesh peering for multiple VPCs

2 participants