Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -430,13 +430,22 @@ jobs:
MAJOR_MINOR=$(echo "${VERSION}" | cut -d. -f1,2)
echo "major_minor_version=${MAJOR_MINOR}" >> "$GITHUB_OUTPUT"

# `release/v2.1` integration tests still invoke `grpcurl`, which
# `main`'s build containers no longer include. Keep canonical v2.1
# checks on `v2.1-latest`; mirrors continue using the `latest` tag from
# their configured source registry.
build_container_fallback_version=latest
if [[ "${GITHUB_REPOSITORY}" == "NVIDIA/infra-controller" && "${MAJOR_MINOR}" == "v2.1" ]]; then
build_container_fallback_version="${MAJOR_MINOR}-latest"
fi
Comment thread
coderabbitai[bot] marked this conversation as resolved.

if [[ "$build_container_x86_64_run" == "true" ]]; then
echo "build_container_x86_64_version=${VERSION}" >> "$GITHUB_OUTPUT"
echo "build_container_x86_64_ref=${TARGET_REGISTRY}/build-container-x86_64:${VERSION}" >> "$GITHUB_OUTPUT"
echo "build_container_x86_64_version_latest=${TARGET_REGISTRY}/build-container-x86_64:${MAJOR_MINOR}-latest" >> "$GITHUB_OUTPUT"
else
echo "build_container_x86_64_version=latest" >> "$GITHUB_OUTPUT"
echo "build_container_x86_64_ref=${SOURCE_REGISTRY}/build-container-x86_64:latest" >> "$GITHUB_OUTPUT"
echo "build_container_x86_64_version=${build_container_fallback_version}" >> "$GITHUB_OUTPUT"
echo "build_container_x86_64_ref=${SOURCE_REGISTRY}/build-container-x86_64:${build_container_fallback_version}" >> "$GITHUB_OUTPUT"
Comment thread
chet marked this conversation as resolved.
echo "build_container_x86_64_version_latest=" >> "$GITHUB_OUTPUT"
fi

Expand All @@ -455,8 +464,8 @@ jobs:
echo "build_container_aarch64_ref=${TARGET_REGISTRY}/build-container-aarch64:${VERSION}" >> "$GITHUB_OUTPUT"
echo "build_container_aarch64_version_latest=${TARGET_REGISTRY}/build-container-aarch64:${MAJOR_MINOR}-latest" >> "$GITHUB_OUTPUT"
else
echo "build_container_aarch64_version=latest" >> "$GITHUB_OUTPUT"
echo "build_container_aarch64_ref=${SOURCE_REGISTRY}/build-container-aarch64:latest" >> "$GITHUB_OUTPUT"
echo "build_container_aarch64_version=${build_container_fallback_version}" >> "$GITHUB_OUTPUT"
echo "build_container_aarch64_ref=${SOURCE_REGISTRY}/build-container-aarch64:${build_container_fallback_version}" >> "$GITHUB_OUTPUT"
echo "build_container_aarch64_version_latest=" >> "$GITHUB_OUTPUT"
fi

Expand Down
15 changes: 10 additions & 5 deletions crates/libmlx-model/src/nvconfig.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@ const GB200_B3240_V1_PARAMETERS: [&str; 18] = [
"PCI_SWITCH0_UPSTREAM_PORT_PEX=0",
];

const GB200_B3240_PART_NUMBERS: [&str; 3] = [
const GB200_B3240_PART_NUMBERS: [&str; 5] = [
"900-9D3B6-00CN-AB0",
"900-9D3B6-00CN-PA0",
"900-9D3B6-00SN-AB0",
"900-9D3B6-00CN-PN0",
"900-9D3B6-00CN-P_Ax",
];

/// `DpuNvConfigProfile` identifies a fixed version of platform mlxconfig values.
Expand All @@ -59,9 +61,10 @@ pub enum DpuNvConfigProfile {
impl DpuNvConfigProfile {
/// Returns the GB200 profile for an exact supported B3240 part number.
///
/// Accepted part numbers are `900-9D3B6-00CN-AB0`, `900-9D3B6-00SN-AB0`,
/// and `900-9D3B6-00CN-PA0`. Surrounding whitespace and ASCII letter case
/// are ignored. The caller must separately verify that the DPU belongs to a
/// Accepted identities are `900-9D3B6-00CN-AB0`, `900-9D3B6-00SN-AB0`,
/// `900-9D3B6-00CN-PA0`, `900-9D3B6-00CN-PN0`, and
/// `900-9D3B6-00CN-P_Ax`. Surrounding whitespace and ASCII letter case are
/// ignored. The caller must separately verify that the DPU belongs to a
/// GB200 rack. Broader B3240 product prefixes are not accepted.
pub fn for_gb200_b3240_part_number(part_number: &str) -> Option<Self> {
let part_number = part_number.trim();
Expand Down Expand Up @@ -90,10 +93,12 @@ mod tests {
fn gb200_b3240_profile_requires_an_exact_supported_part_number() {
value_scenarios!(
run = DpuNvConfigProfile::for_gb200_b3240_part_number;
"supported part numbers" {
"supported identities" {
"900-9D3B6-00CN-AB0" => Some(DpuNvConfigProfile::Gb200B3240V1),
"900-9D3B6-00SN-AB0" => Some(DpuNvConfigProfile::Gb200B3240V1),
"900-9D3B6-00CN-PA0" => Some(DpuNvConfigProfile::Gb200B3240V1),
"900-9D3B6-00CN-PN0" => Some(DpuNvConfigProfile::Gb200B3240V1),
"900-9D3B6-00CN-P_Ax" => Some(DpuNvConfigProfile::Gb200B3240V1),
" 900-9d3b6-00cn-pa0\n" => Some(DpuNvConfigProfile::Gb200B3240V1),
}

Expand Down
Loading