improve ssh key handling in e2e workflow #1552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use trap to ensure temp key file cleanup on exit - use printf instead of echo for safer secret handling Signed-off-by: luojiyin <[email protected]>
luojiyin1987
force-pushed
the
security/e2e-ssh-key-handling
branch
from
cae7d42 to
8ac79f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
trapto ensure temp SSH key file is cleaned up on exitprintf '%s'instead ofechofor safer secret handling (avoids escape character interpretation)Test plan
🤖 Generated with Claude Code