Skip to content

[FEA] remove unnecessary keys selection and fuse selection to erase #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShaobinChen-AH wants to merge 2 commits into from
Closed

[FEA] remove unnecessary keys selection and fuse selection to erase #404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c4fee5
[FEA] remove unnecessary keys selection and fuse selection to erase
ShaobinChen-AH May 22, 2026
1012a86
fix
ShaobinChen-AH May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions corelib/dynamicemb/dynamicemb/batched_dynamicemb_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,12 +349,11 @@ def _prefetch_cache_path(
keys_to_insert_mask = storage_founds.clone()

if new_in_miss.any() and admit_strategy is not None:
new_miss_indices = torch.where(new_in_miss)[0]
new_keys_sub = miss_keys[new_miss_indices]
new_tids_sub = miss_tids[new_miss_indices]
new_keys_sub = miss_keys[new_in_miss]
new_tids_sub = miss_tids[new_in_miss]

freq_for_admission = (
miss_lfu_freq[new_miss_indices] if miss_lfu_freq is not None else None
miss_lfu_freq[new_in_miss] if miss_lfu_freq is not None else None
)
counters = (
freq_for_admission
Expand All @@ -368,12 +367,11 @@ def _prefetch_cache_path(
admission_counter.erase(
new_keys_sub[admit_mask], new_tids_sub[admit_mask]
)
keys_to_insert_mask[new_miss_indices[admit_mask]] = True
keys_to_insert_mask[new_in_miss] = admit_mask

non_admit = ~admit_mask
if non_admit.any():
non_admitted_miss_pos = new_miss_indices[non_admit]
non_admitted_positions = miss_compact_idx[non_admitted_miss_pos]
non_admit_miss = new_in_miss & ~keys_to_insert_mask
if non_admit_miss.any():
non_admitted_positions = miss_compact_idx[non_admit_miss]
elif new_in_miss.any():
keys_to_insert_mask = torch.ones(
h_num_miss, dtype=torch.bool, device=device
Expand Down