Skip to content

fix(edm2-sample): multistep_corrector_update crashes for (+1 more) - #6

Open
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/edm2-sample-assorted-7e2588f4
Open

fix(edm2-sample): multistep_corrector_update crashes for (+1 more)#6
andrewwhitecdw wants to merge 1 commit into
NVlabs:mainfrom
andrewwhitecdw:bugfix/edm2-sample-assorted-7e2588f4

Conversation

@andrewwhitecdw

@andrewwhitecdw andrewwhitecdw commented Jul 27, 2026

Copy link
Copy Markdown

Small fixes in EDM2_sample.py:

fix: multistep_corrector_update crashes for order=1 with IndexError

Fix: Replace:

        indexes = [-i - 1 for i in range(n + 1)]

with:

        indexes = [-i - 1 for i in range(max(n + 1, 2))]

fix: DPM_Solver_v3 references missing total_N when t_end is None

Fix: Replace:

        t_0 = 1.0 / self.noise_schedule.total_N if t_end is None else t_end

with:

        assert t_end is not None, "t_end must be specified for NoiseScheduleEDM"
        t_0 = t_end

Files changed

  • EDM2_sample.py

@andrewwhitecdw
andrewwhitecdw marked this pull request as ready for review July 27, 2026 21:28
@andrewwhitecdw

Copy link
Copy Markdown
Author

Closing this sweep-generated PR: PR has 3 commits; sweep requires exactly one commit per PR. It does not meet the sweep requirements (single signed-off commit).

Signed-off-by: Andrew White <andrewwhitecdw@users.noreply.github.com>
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw force-pushed the bugfix/edm2-sample-assorted-7e2588f4 branch from 0d414da to 9ac5ad6 Compare August 18, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant