Fix Windows path separator bug in registerNativeComponents()#163
Open
rdanklof wants to merge 1 commit into
Open
Fix Windows path separator bug in registerNativeComponents()#163rdanklof wants to merge 1 commit into
rdanklof wants to merge 1 commit into
Conversation
On Windows, SplFileInfo::getPathname() returns backslashes, causing str_replace() with a forward-slash base path to never match. Normalize both paths to forward slashes before comparing so component registration works on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some developers are required to work on Windows due to company policy. When testing via the Jump app on Windows, native components (e.g. `native:bottom-nav`) failed to register because `SplFileInfo::getPathname()` returns backslashes, while the base path was stripped using a hardcoded `/` separator.
Fixed by normalizing both paths with `str_replace('\\', '/')` and using `substr` + `strlen` to extract the relative path.
Test plan