Skip to content

Fix Android compile against cores without the background-layer transparency local #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanerbaner82 merged 1 commit into from
Aug 4, 2026
Merged

Fix Android compile against cores without the background-layer transparency local #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions resources/android/NativeUIBackgroundLayerHost.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ package com.nativephp.plugins.native_ui.ui
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.ui.Modifier
import com.nativephp.mobile.ui.nativerender.LocalBackgroundLayerPresent
import com.nativephp.mobile.ui.nativerender.NativeRendererRegistry
import com.nativephp.mobile.ui.nativerender.NativeUINode
import com.nativephp.mobile.ui.nativerender.NodeView
Expand All @@ -17,8 +15,12 @@ import com.nativephp.mobile.ui.nativerender.NodeView
* MapLibre MapView, a player) survives every publish: tab switches and
* pushes update props in place instead of recreating the native view.
*
* Provides [LocalBackgroundLayerPresent] so opaque chrome (the tabs
* Scaffold) knows to go transparent above the layer.
* NOTE: this file must compile against every core this plugin installs
* into — it must not reference core symbols that only exist on newer
* cores. The `LocalBackgroundLayerPresent` transparency signal (so the
* tabs Scaffold can go transparent above the layer) returns here once
* the distributed core ships that composition local alongside the
* tabs-hosting work.
*/
@Composable
fun NativeUIBackgroundLayerHost(
Expand Down Expand Up @@ -50,8 +52,6 @@ fun NativeUIBackgroundLayerHost(

// Content composes SECOND — Compose draws later Box children on
// top, which is what keeps the layer beneath the screen.
CompositionLocalProvider(LocalBackgroundLayerPresent provides true) {
content()
}
content()
}
}
Loading