Silence the deprecated databaseEnabled warning in the webview lockdown - #49
Merged
Merged
Conversation
`WebSettings.databaseEnabled` was deprecated in API 33 — the Web SQL Database API it gates has since been removed from WebView entirely — so it warns on every compileDebugKotlin. Suppressed rather than deleted. `minSdk` is 26, and on an older device carrying an older WebView the setting still does something; dropping it would quietly weaken this lockdown on exactly the devices that need it most. `allowFileAccessFromFileURLs` and `allowUniversalAccessFromFileURLs` two lines above are suppressed for the same reason, so this also keeps the block internally consistent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSettings.databaseEnabledwas deprecated in API 33 — the Web SQL Database API it gates has since been removed from WebView entirely — so it warns on everycompileDebugKotlin:Suppressed rather than deleted.
minSdkis 26, and on an older device carrying an older WebView the setting still does something — dropping it would quietly weaken this lockdown on exactly the devices that need it most. Deleting would also have been almost safe for a different reason (the platform default is alreadyfalse), but this block deliberately asserts each setting rather than relying on defaults, and I'd rather not erode that.allowFileAccessFromFileURLsandallowUniversalAccessFromFileURLstwo lines above are suppressed for exactly the same reason, so this keeps the block internally consistent too.Independent of #47 and #48 — different file, merges in any order.
🤖 Generated with Claude Code