Fix bundle purchases summary showing identical totals for every row#288
Merged
Conversation
The correlated subqueries for sale_total and sale_plugins_count referenced the unaliased plugin_licenses table, making whereColumn correlate against itself (always true). Aliased inner tables as sale_pl/count_pl so values are computed per user/purchase. Added tests for computed column correctness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugin_licensestable, causingwhereColumnto correlate against itself (always true) instead of the outer querysale_plandcount_plsosale_totalandsale_plugins_countare computed correctly per user/purchaseTest plan
test_it_computes_correct_totals_per_saleverifies a single buyer's totalstest_it_computes_correct_totals_for_each_buyerverifies different buyers get independent totals🤖 Generated with Claude Code