Skip to content

Fix Filament v5 Get/Set type hint namespace in resource forms#300

Merged
simonhamp merged 1 commit into
mainfrom
fix-wall-of-love-form-get-type
Mar 27, 2026
Merged

Fix Filament v5 Get/Set type hint namespace in resource forms#300
simonhamp merged 1 commit into
mainfrom
fix-wall-of-love-form-get-type

Conversation

@simonhamp

Copy link
Copy Markdown
Member

Summary

  • Updated all Filament resource form closures to use Filament\Schemas\Components\Utilities\Get and Set instead of the removed Filament\Forms\Get and Filament\Forms\Set (Filament v5 breaking change)
  • Fixed 5 affected resources: WallOfLoveSubmissionResource, ShowcaseResource, ProductResource, PluginBundleResource, ArticleResource
  • Added test coverage for the WallOfLoveSubmission edit page (pending, approved, promoted states)

Fixes #46

Test plan

  • Existing tests pass
  • New WallOfLoveSubmissionResourceTest covers edit page rendering for pending, approved, and promoted submissions
  • Manually verify the Wall of Love edit page loads without errors in the admin panel

🤖 Generated with Claude Code

Update closures in Filament resource forms to use the new
Filament\Schemas\Components\Utilities\Get and Set classes instead of
the removed Filament\Forms\Get and Filament\Forms\Set.

Fixes #46

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@simonhamp simonhamp marked this pull request as ready for review March 27, 2026 11:27
@simonhamp simonhamp merged commit efffb6c into main Mar 27, 2026
2 checks passed
@simonhamp simonhamp deleted the fix-wall-of-love-form-get-type branch March 27, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant