Fix Ultra subscribers getting 402 when installing official plugins#326
Merged
Conversation
Plugin access checks only looked at team membership (isUltraTeamMember), which requires creating a team first. Ultra subscribers who hadn't created a team yet were denied access to official plugins. Now also checks hasUltraAccess() (the subscription itself) in both hasPluginAccess() and the Satis API listing endpoint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nativephp/mobile-secure-storage)hasPluginAccess()andgetAccessiblePlugins()) only checkedisUltraTeamMember(), which requires an existing team — they didn't checkhasUltraAccess()(the subscription itself)hasUltraAccess()as an alternative condition for official plugin access in both the model method and the Satis API controllerTest plan
checkAccessendpoint returns true for Ultra subscriber without a team🤖 Generated with Claude Code