Added auth with bot token and support for ids for --to#181
Open
Forden wants to merge 3 commits into
Open
Conversation
Nekmo
requested changes
Jun 15, 2023
Nekmo
left a comment
Nekmo
left a comment
Owner
There was a problem hiding this comment.
The code is fine but documentation and tests are needed. Thanks!
| to = async_to_sync(interactive_select_dialog(client)) | ||
| elif to is None: | ||
| to = 'me' | ||
| elif to is not None: |
Owner
There was a problem hiding this comment.
This code is now unnecessary. Also, it doesn't follow the Python style rules. You should never use except without defining an exception. It is also preferable to validate numbers without using exceptions. The use of defining the variable _ is not necessary.
| try: | ||
| return super().start(phone=phone, password=password, bot_token=bot_token, force_sms=force_sms, | ||
| first_name=first_name, last_name=last_name, max_attempts=max_attempts) | ||
| return super().start(phone=config.get('phone', None), password=config.get('password', None), |
Owner
There was a problem hiding this comment.
The code must be prepared in case the token bot and the phone were on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple patch to allow using bot tokens to auth as a bot and use integer ids instead of only strings