Skip to content

Close uploaded files before deleting#289

Draft
Mirochill wants to merge 1 commit into
Nekmo:masterfrom
Mirochill:fix-280-close-before-delete
Draft

Close uploaded files before deleting#289
Mirochill wants to merge 1 commit into
Nekmo:masterfrom
Mirochill:fix-280-close-before-delete

Conversation

@Mirochill

Copy link
Copy Markdown

Summary:

  • Close the uploaded File object before --delete-on-success removes the local path.
  • Keep the existing delete-on-success behavior after successful uploads.
  • Add a regression that checks close happens before os.remove().

Fixes: #280

Validation:

  • git diff --check
  • git diff --check HEAD~1..HEAD
  • Not run locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: --delete-on-success never works

1 participant