fix(ui): snapshot rename looks unsaved and labels render too small - #698
Merged
Conversation
onFinish called toggle() a third time after the try/catch, so every submit
flipped the editor twice and it ended up open again. A rename saved correctly
and still showed its input, which reads as a field that refused to save.
The Form also carried onBlur, which never fired: component={false} drops the
rest props, so leaving a cell neither saved nor cancelled and the editor stayed
open until Enter. Blur now submits, matching submitOnBlur on
InlineEditWithButtons, and LabelsEdit no longer cancels on its own - a label
edit was silently discarded when the user clicked away.
Two testing-page specs asserted the old behavior by looking for an input after
Enter. They now look for the committed value, which is what their comments
already described.
Closes #679
A read-state label rendered at fontSizeSM, which the app's base size of 13 puts at 10px in a 13px cell, so labels looked shrunken next to the chips the editor shows. They now take the cell's size and the chip's box. The inline-edit rule that pads controls to the cell listed .ant-select-selector, a class antd v6 no longer emits, so the labels editor kept its own inset and its chips sat 4px left of the read state. It targets .ant-select instead. The hover border was a hardcoded #d9d9d9, which stayed light grey in the dark theme; it reads --ant-color-border now.
The suite runs in jsdom and had nothing on InlineEdit, so both defects #679 reports passed it. These fail when the trailing toggle() returns and when the relatedTarget guard on blur is dropped, which is what makes them worth keeping.
AkhDmitrii
marked this pull request as ready for review
August 27, 2026 05:56
The value dropped from 5px to 4px so a 24px label chip keeps the row at 32px. Nothing in the suite fails if someone restores 5px, and every table row grows by 2px.
github-actions
Bot
added
the
documentation
|
|
AkhDmitrii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A chain's Snapshots tab. Its Name and Labels columns are edited in place: click a cell, it
turns into a field, press Enter.
Issue #679 reports two things, and one frame shows both. The name below was saved — the request
returned 200 — but the cell still shows a bordered input, so it reads as a field that refused to
save. The labels next to it render smaller than the ones the editor shows.
After:
Working the same cell turned up a third problem the issue does not mention: typing a name and
clicking away did nothing at all. No save, no cancel, and the editor stayed open until Enter.
Editing a label and clicking away threw the edit away without saying so.
What
InlineEditWithButtonsalready does throughsubmitOnBlur.This is the shared inline-edit component, so the behavior changes on every table that uses it,
not only on snapshots.
How to verify
Open a chain, go to Snapshots, and on a snapshot that carries labels:
250 suites, 3473 tests.
For the reviewer
tests/pages/testing/asserted the old behavior by looking for aninputafter Enter. They now look for the committed value, which is what their own comments already
described.
InlineEditcall sites. Three mapper dialogs resolveonSubmitafter showing an error toast, so a rejected value now closes the editor rather than staying
open. Worth a look before merge.
Closes #679