feat(bcast): add broadcast_and_wait for bcast#384
Merged
Conversation
varex83
approved these changes
May 11, 2026
mskrzypkows
reviewed
May 11, 2026
mskrzypkows
approved these changes
May 11, 2026
Co-authored-by: Maciej Skrzypkowski <mskr@gmx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes DKG broadcast observable by callers that need completion.
Before,
bcast::Component::broadcast()only enqueued work. Actual send success/failure arrived later asbcast::Event, but nodesigs and FROST flows had already moved on or were waiting elsewhere. That meant a failed broadcast could be dropped or ignored, causing DKG to hang until cancellation instead of failing with the real send error.The fix adds
broadcast_and_wait(): it enqueues the broadcast and waits for the behaviour’s terminal status. Nodesigs and FROST now use this API before continuing, so broadcast failures propagate immediately through their normal error paths. The old enqueue-onlybroadcast()remains for callers that consume events separately.