Skip to content

fix: register MonetHelper overlay receiver in LaunchActivity - #202

Merged
omg-xtao merged 2 commits into
NextAlone:devfrom
waifucon:fix-monet-theme
Oct 8, 2026
Merged

omg-xtao merged 2 commits into
NextAlone:devfrom
waifucon:fix-monet-theme

Conversation

@waifucon

@waifucon waifucon commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Commit 9fff4fd1 introduced an OverlayChangeReceiver inside MonetHelper to listen for the android.intent.action.OVERLAY_CHANGED broadcast intent. The goal was to dynamically refresh the active theme when system Monet colors changed. However, the registerReceiver and unregisterReceiver methods were never actually invoked, meaning the receiver was inactive and users had to manually restart the app to see theme changes.

This PR correctly wires the receiver by adding:

  • MonetHelper.registerReceiver(this) in LaunchActivity#onCreate
  • MonetHelper.unregisterReceiver(this) in LaunchActivity#onDestroy

This ensures that the broadcast receiver is properly bound to the app's lifecycle, allowing the app theme to refresh seamlessly on the fly.

Summary by Sourcery

Bug Fixes:

  • Register and unregister the Monet overlay receiver with LaunchActivity's lifecycle so theme colors refresh automatically when system Monet colors change.

@sourcery-ai

sourcery-ai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

LaunchActivity now registers and unregisters MonetHelper’s overlay receiver with its activity lifecycle, enabling automatic theme refreshes when Android Monet colors change without requiring an app restart.

Sequence diagram for Monet overlay-driven theme refresh

sequenceDiagram
    participant LaunchActivity
    participant MonetHelper
    participant Android

    LaunchActivity->>MonetHelper: registerReceiver(this)
    Android-->>MonetHelper: OVERLAY_CHANGED
    MonetHelper->>MonetHelper: refresh active theme
    LaunchActivity->>MonetHelper: unregisterReceiver(this)
Loading

File-Level Changes

Change Details Files
Bind MonetHelper’s overlay-change receiver to LaunchActivity’s lifecycle.
  • Import MonetHelper into LaunchActivity.
  • Register the receiver during onCreate.
  • Unregister the receiver during onDestroy.
TMessagesProj/src/main/java/org/telegram/ui/LaunchActivity.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@omg-xtao omg-xtao added the bug Something isn't working label Oct 8, 2026
@omg-xtao
omg-xtao merged commit df1cc12 into NextAlone:dev Oct 8, 2026
0 of 3 checks passed
@waifucon
waifucon deleted the fix-monet-theme branch October 8, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants