Make fix reformats, with Python set to 39 - #304
Merged
Conversation
robin-nitrokey
approved these changes
Dec 19, 2022
robin-nitrokey
left a comment
robin-nitrokey
left a comment
Member
There was a problem hiding this comment.
Nice! I already wondered why the dataclass import is misplaced …
| help="Force pcscd and GnuPG services restart once finished", | ||
| ) | ||
| def set_identity(identity, force_restart): | ||
| def set_identity(identity): |
Member
Author
There was a problem hiding this comment.
Ah, looks so indeed. Will look into that during the merge, good spot!
5 tasks
szszszsz
force-pushed
the
update-black-isort-to-p39
branch
from
December 29, 2022 09:12
692cb58 to
b1cc639
Compare
szszszsz
force-pushed
the
update-black-isort-to-p39
branch
from
December 29, 2022 09:13
b1cc639 to
cc87062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the rules to use Python 3.9. The "35" used until now is not available in the latest black/isort releases, thus fail on the new setups.
Changes
Checklist
make checkormake fixfor the formatting check