Skip to content

PIV import and PUK fixes - #766

Merged
robin-nitrokey merged 1 commit into
Nitrokey:mainfrom
ABuljko:piv-import-and-puk
Aug 19, 2026
Merged

PIV import and PUK fixes#766
robin-nitrokey merged 1 commit into
Nitrokey:mainfrom
ABuljko:piv-import-and-puk

Conversation

@ABuljko

@ABuljko ABuljko commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • cli/nk3/piv.py - RSA import: encode primes p/q as 128 bytes, not 256
  • nk3/piv_app.py - change_puk: check len(new_puk_bytes) instead of len(new_puk)

@ABuljko ABuljko changed the title piv: fix RSA import prime length and PUK length check PIV import and PUK fixes Jul 4, 2026
@ABuljko
ABuljko marked this pull request as ready for review July 4, 2026 19:48
@ABuljko
ABuljko requested a review from a team as a code owner July 4, 2026 19:48
@ABuljko
ABuljko requested review from daringer, james-knippes, mmerklinger, robin-nitrokey and sosthene-nitrokey and removed request for a team July 4, 2026 19:48
@sosthene-nitrokey
sosthene-nitrokey changed the base branch from master to main July 29, 2026 15:10
@robin-nitrokey
robin-nitrokey merged commit 3352231 into Nitrokey:main Aug 19, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daringer daringer daringer approved these changes
@robin-nitrokey robin-nitrokey robin-nitrokey approved these changes
@sosthene-nitrokey sosthene-nitrokey sosthene-nitrokey approved these changes
@james-knippes james-knippes Awaiting requested review from james-knippes james-knippes is a code owner automatically assigned from Nitrokey/python-reviewers
@mmerklinger mmerklinger Awaiting requested review from mmerklinger mmerklinger is a code owner automatically assigned from Nitrokey/python-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ABuljko @daringer @wlatendresse @robin-nitrokey @sosthene-nitrokey