Replace Path with std::filesystem::path in libfetchers. #14652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Ericson2314 merged 2 commits into NixOS:master from vinayakankugoyal:path

Nov 26, 2025

Contributor

vinayakankugoyal commented Nov 26, 2025

Motivation

Replace Path with std::filesystem::path in libfetchers.

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

vinayakankugoyal requested review from Ericson2314 and edolstra as code owners

November 26, 2025 04:02

github-actions bot added store fetching c api labels

vinayakankugoyal force-pushed the path branch from e1e3069 to 5fe4c87 Compare

November 26, 2025 04:13

Ericson2314 reviewed

View reviewed changes

src/libfetchers/git-lfs-fetch.cc Outdated Show resolved Hide resolved

Ericson2314 reviewed

View reviewed changes

src/libfetchers/mercurial.cc Show resolved Hide resolved

Ericson2314 reviewed

View reviewed changes

src/libfetchers/mercurial.cc Show resolved Hide resolved

Ericson2314 reviewed

View reviewed changes

src/libfetchers/mercurial.cc Show resolved Hide resolved

Ericson2314 reviewed

View reviewed changes

src/libfetchers/registry.cc Outdated Show resolved Hide resolved

Ericson2314 reviewed

View reviewed changes

src/libfetchers/registry.cc Show resolved Hide resolved

Ericson2314 reviewed

View reviewed changes

src/libfetchers/registry.cc Show resolved Hide resolved

Ericson2314 reviewed

View reviewed changes

src/libstore/local-store.cc Outdated Show resolved Hide resolved

Member

Ericson2314 commented Nov 26, 2025

       > ../globals.cc:489:9: error: no matching function for call to 'hasPrefix'
       >   489 |     if (hasPrefix(defaultTempDir(), "/var/folders/"))
       >       |         ^~~~~~~~~

Can do a bit nicer with https://en.cppreference.com/w/cpp/filesystem/path/lexically_normal

Member

Ericson2314 commented Nov 26, 2025

@xokdvium let me know if you think my makeFSSourceAccessor suggestions are too much for now because potential symlink issues.

Ericson2314 reviewed

View reviewed changes

src/libfetchers/git-utils.cc Outdated Show resolved Hide resolved


          Use std::filesystem::path instead of Path in libexpr.

e761a9f

Ericson2314 force-pushed the path branch from becb101 to 4372269 Compare

November 26, 2025 16:19

Ericson2314 approved these changes

View reviewed changes

Ericson2314 force-pushed the path branch from af96799 to 4372269 Compare

November 26, 2025 16:23


          Replace Path with std::filesystem::path in libfetchers.

f039075

Ericson2314 force-pushed the path branch from 4372269 to f039075 Compare

November 26, 2025 16:23

Ericson2314 enabled auto-merge

November 26, 2025 16:24

Ericson2314 added this pull request to the merge queue

Merged via the queue into NixOS:master with commit 3c2d5a1

16 checks passed

xokdvium mentioned this pull request

MinGW build is broken again #14662

Open

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c api fetching store