Skip to content

feat: use coinank free API for kline data and show exchange badge#1285

Merged
tinkle-community merged 1 commit into
feat/coinankfrom
dev
Dec 27, 2025
Merged

feat: use coinank free API for kline data and show exchange badge#1285
tinkle-community merged 1 commit into
feat/coinankfrom
dev

Conversation

@tinkle-community

@tinkle-community tinkle-community commented Dec 27, 2025

Copy link
Copy Markdown
Collaborator

Pull Request - Frontend | 前端 PR

💡 提示 Tip: 推荐 PR 标题格式 type(scope): description
例如: feat(ui): add dark mode toggle | fix(form): resolve validation bug


📝 Description | 描述

English:中文:


🎯 Type of Change | 变更类型

  • 🐛 Bug fix | 修复 Bug
  • ✨ New feature | 新功能
  • 💥 Breaking change | 破坏性变更
  • 🎨 Code style update | 代码样式更新
  • ♻️ Refactoring | 重构
  • ⚡ Performance improvement | 性能优化

🔗 Related Issues | 相关 Issue

  • Closes # | 关闭 #
  • Related to # | 相关 #

📋 Changes Made | 具体变更

English:中文:


📸 Screenshots / Demo | 截图/演示

Before | 变更前:

After | 变更后:


🧪 Testing | 测试

Test Environment | 测试环境

  • OS | 操作系统:
  • Node Version | Node 版本:
  • Browser(s) | 浏览器:

Manual Testing | 手动测试

  • Tested in development mode | 开发模式测试通过
  • Tested production build | 生产构建测试通过
  • Tested on multiple browsers | 多浏览器测试通过
  • Tested responsive design | 响应式设计测试通过
  • Verified no existing functionality broke | 确认没有破坏现有功能

🌐 Internationalization | 国际化

  • All user-facing text supports i18n | 所有面向用户的文本支持国际化
  • Both English and Chinese versions provided | 提供了中英文版本
  • N/A | 不适用

✅ Checklist | 检查清单

Code Quality | 代码质量

  • Code follows project style | 代码遵循项目风格
  • Self-review completed | 已完成代码自查
  • Comments added for complex logic | 已添加必要注释
  • Code builds successfully | 代码构建成功 (npm run build)
  • Ran npm run lint | 已运行 npm run lint
  • No console errors or warnings | 无控制台错误或警告

Testing | 测试

  • Component tests added/updated | 已添加/更新组件测试
  • Tests pass locally | 测试在本地通过

Documentation | 文档

  • Updated relevant documentation | 已更新相关文档
  • Updated type definitions (TypeScript) | 已更新类型定义
  • Added JSDoc comments where necessary | 已添加 JSDoc 注释

Git

  • Commits follow conventional format | 提交遵循 Conventional Commits 格式
  • Rebased on latest dev branch | 已 rebase 到最新 dev 分支
  • No merge conflicts | 无合并冲突

📚 Additional Notes | 补充说明

English:中文:


By submitting this PR, I confirm | 提交此 PR,我确认:

  • I have read the Contributing Guidelines | 已阅读贡献指南
  • I agree to the Code of Conduct | 同意行为准则
  • My contribution is licensed under AGPL-3.0 | 贡献遵循 AGPL-3.0 许可证

🌟 Thank you for your contribution! | 感谢你的贡献!

- Switch to coinank free/open kline API (no authentication required)
- Add exchange badge display with brand colors (Binance/Bybit/OKX/Hyperliquid/Aster)
- Auto-convert OKX symbol format (BTCUSDT -> BTC-USDT-SWAP)
- Fallback to Binance data for unsupported exchanges (Bitget/Lighter)
- Pass exchange prop from trader account to chart component
@tinkle-community
tinkle-community merged commit 2740bfb into feat/coinank Dec 27, 2025
19 of 23 checks passed
@github-actions

Copy link
Copy Markdown

🎨 已自动应用专用模板 | Auto-Applied Template

检测到您的PR主要包含 frontend 相关的变更,系统已自动为您应用相应的模板。

Detected that your PR primarily contains frontend changes. The appropriate template has been automatically applied.

文件统计 | File Statistics

  • 🔧 Go files: 2
  • 🎨 TypeScript files: 3

已应用模板 | Applied Template
.github/PULL_REQUEST_TEMPLATE/frontend.md

✨ 您现在可以直接在PR描述中填写相关信息了!

✨ You can now fill in the relevant information in the PR description!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant