Fix #244 - Remove CSV and old-format JSON formatting #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lars-t-hansen
commented
Nov 12, 2025
lars-t-hansen
commented
Nov 12, 2025
lars-t-hansen
force-pushed
the
larstha-244-no-csv
branch
from
3c56f41 to
1cc9dae
Compare
Collaborator
Author
|
A little more work to do here:
|
Collaborator
Author
|
Also doc/CHANGELOG.md mentions the "new" format. |
Collaborator
Author
|
I guess arguably "util/formats/newfmt" is also a misnomer; "json" might be better. And newfmt/to_oldfmt.go can be removed as well. Going to convert this to draft until I'm sure that I'm done. |
lars-t-hansen
force-pushed
the
larstha-244-no-csv
branch
from
5a79109 to
786ed6f
Compare
Collaborator
Author
|
Not going to rename 'newfmt' to something else, partly because I don't know what that something else should be and partly because this would be disruptive to much of the code and to Jobanalyzer as well. May consider it in the future when things are clearer. For now, leave a pointer in util/formats/README.md about why it's the "new" format and where to find information about the old format. |
lars-t-hansen
commented
Nov 13, 2025
lars-t-hansen
commented
Nov 13, 2025
lars-t-hansen
commented
Nov 13, 2025
lars-t-hansen
force-pushed
the
larstha-244-no-csv
branch
from
786ed6f to
944fda6
Compare
Collaborator
Author
|
@bast, I think this is all I'm prepared to do at this point, LMK what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the prep work had been done so this is pretty undramatic.