motor-temp-sensor-fault#204
Merged
Merged
Conversation
jr1221
requested changes
May 15, 2026
Contributor
jr1221
left a comment
jr1221
left a comment
There was a problem hiding this comment.
Looks great. But sorry I have changed my mind. Can this be a critical fault?
Contributor
Author
|
Yeah, will change that and lyk
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Jack Rubacha ***@***.***>
Sent: Thursday, May 14, 2026 10:34:47 PM
To: Northeastern-Electric-Racing/Cerberus-2.0 ***@***.***>
Cc: Sakthivel Ponnampalayam Sivakumar ***@***.***>; Author ***@***.***>
Subject: Re: [Northeastern-Electric-Racing/Cerberus-2.0] motor-temp-sensor-fault (PR #204)
@jr1221 requested changes on this pull request.
Looks great. But sorry I have changed my mind. Can this be a critical fault?
—
Reply to this email directly, view it on GitHub<#204 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BN547EETXZQWJPN2XD3AIND42Z64PAVCNFSM6AAAAACYGRRMFKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DEOJUHA2TEOJQHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jr1221
approved these changes
May 23, 2026
Contributor
|
Can you just open a corresponding PR on Odyssey Definitions to add the fault? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a new non-critical fault "MOTOR_TEMP_SENSOR_FAULT" and added a sanity check condition before radfan and pump2 efuse block.