4090 maintenance schema changes move notifications to event level#4153
Open
4090 maintenance schema changes move notifications to event level#4153
Conversation
…anged services so that they check event instead of eventtype for sendslacknotifs
…teEvent service calls
4 tasks
…y anymore (it directly checks event for sendSlackNotifs)
… the correct places
cielbellerose
requested changes
Apr 16, 2026
Contributor
cielbellerose
left a comment
cielbellerose
left a comment
There was a problem hiding this comment.
this looks awesome! only one small schema note. also make sure you are merging into the feature/event-notifications branch so we can merge BE and FE at the same time when the time comes
|
|
||
| */ | ||
| -- AlterTable | ||
| ALTER TABLE "Event" ADD COLUMN "sendSlackNotifications" BOOLEAN NOT NULL; |
Contributor
There was a problem hiding this comment.
we should default this to false so it works with the existing events, also we don't need to include the above comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Moved sendSlackNotifications from Event_Type to Event for routes, controllers, services, transformers, and in prisma and shared types. Created schema migration. Updated tests to match the new location of sendSlackNotifications, and tests (for backend) pass.
Screenshots
Create event route works
Edit event route works
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4090