Skip to content

#4000 guest definition admin tools#4154

Open
staysgt wants to merge 4 commits intodevelopfrom
#4000-guest-definition-admin
Open

#4000 guest definition admin tools#4154
staysgt wants to merge 4 commits intodevelopfrom
#4000-guest-definition-admin

Conversation

@staysgt
Copy link
Copy Markdown
Contributor

@staysgt staysgt commented Apr 14, 2026

Changes

Created the admin tools for guest definitions, including the table to display, the create and edit modals. Abstracted so both types use the same components.

Screenshots

Screenshot 2026-04-14 at 6 55 14 PM Screenshot 2026-04-14 at 6 55 30 PM Screenshot 2026-04-14 at 6 55 41 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4000
Closes #4125

@staysgt staysgt self-assigned this Apr 14, 2026
@staysgt staysgt requested review from chpy04 and wavehassman April 14, 2026 23:10
Comment thread src/frontend/src/pages/AdminToolsPage/EditGuestView/GuestDefinitionsTable.tsx Outdated
Comment thread src/frontend/src/pages/AdminToolsPage/EditGuestView/GuestDefinitionsTable.tsx Outdated
Comment thread src/frontend/src/pages/AdminToolsPage/EditGuestView/GuestDefinitionsTable.tsx Outdated
@staysgt staysgt requested a review from wavehassman April 15, 2026 02:38

useFormPersist(formStorageKey, { watch, setValue });

useEffect(() => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added conditional rendering, you don't need the useEffect here

@staysgt staysgt requested a review from wavehassman April 15, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Guest Page Improvements] - Admin Tools for Info Page [Guest Page Improvements] - Admin Tools Guest Definitions

2 participants