[18.0][MIG] sale_commission_product_criteria_oca: Migration to 18.0#653
Open
FranzPoize wants to merge 17 commits intoOCA:18.0from
Open
[18.0][MIG] sale_commission_product_criteria_oca: Migration to 18.0#653FranzPoize wants to merge 17 commits intoOCA:18.0from
FranzPoize wants to merge 17 commits intoOCA:18.0from
Conversation
Currently translated at 100.0% (65 of 65 strings) Translation: commission-16.0/commission-16.0-sale_commission_product_criteria Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-sale_commission_product_criteria/it/
FranzPoize
force-pushed
the
18.0-mig-sale_commission_product_criteria
branch
4 times, most recently
from
881b72f to
211e015
Compare
FranzPoize
force-pushed
the
18.0-mig-sale_commission_product_criteria
branch
from
211e015 to
d34e2c5
Compare
Author
|
Can someone review this ? @Tisho99 @ilyasProgrammer |
Author
|
It would be great if someone could review this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is a bit rude to create another PR for this migration but I kinda need this to be merged quickly and the PR seems dead for a month.
Module is migrated, tests are running and functionally I tested on a small case and it seems to work.
The module name is changed to reflect the name change of other modules.